Current coverage is 85.25%

Merging #3332 into master will decrease coverage by -0.20% as of eb787a0

@@            master   #3332   diff @@
======================================
  Files          215     215       
  Stmts        15768   15767     -1
  Branches      3385    3383     -2
  Methods          0       0       
======================================
- Hit          13475   13442    -33
- Partial        672     704    +32
  Missed        1621    1621       

Review entire Coverage Diff as of eb787a0

Powered by Codecov. Updated on successful CI builds.

Thanks. And just for clarity, would you mind adding a few more tests?

class Foo {
  x
  y // works
}

class Foo {
  p
  [m] () {} // works
}

class Foo {
  p = x
  [m] () {} // parse error
}

class Foo {
  [p1]
  [p2] // works
}

class Foo {
  [p1] = x
  [p2] // parses as a '[p1] = x[p2];'
}

@jeffmo Sure, I'll add those test cases. I don't think

class Foo {
  [p1]
  [p2] // works
}

would work though.

Actually nevermind. Currently Babel just does not handle parsing assignments to computed properties though.

I added the 3 of the 5 that don't involve computed properties.

Thanks, this looks correct

👍

Currently Babel just does not handle parsing assignments to computed properties though.

@loganfsmyth Do we already have an issue for that one?

@hzoo I don't think we do. I didn't realize it was actually supposed to be supported :p

Awesome! I look forward to the release!

Which version will this be released in?

I added a 6.5.x milestone, so in the next patch release - planning sunday/monday.

A test involving a generator method would be great:

class Foo {
  p = x
  *m () {} // parse error
}

@michaelficarra k I'l do a PR