Fix: Arrow functions with trailing comma + return type are throwing an error when parsing#3305
Merged
amasad merged 1 commit intobabel:masterfrom Feb 5, 2016
Merged
Fix: Arrow functions with trailing comma + return type are throwing an error when parsing#3305amasad merged 1 commit intobabel:masterfrom
amasad merged 1 commit intobabel:masterfrom
Conversation
Current coverage is
|
Member
|
Putting the tests in cc @amasad thoughts? (we can just move this to a patch version) |
Member
|
LGTM |
amasad
added a commit
that referenced
this pull request
Feb 5, 2016
Fix: Arrow functions with trailing comma + return type are throwing an error when parsing
Member
|
I think this is also related to https://phabricator.babeljs.io/T7187 |
JacopKane
pushed a commit
to JacopKane/babel
that referenced
this pull request
Jan 11, 2018
Fix: Arrow functions with trailing comma + return type are throwing an error when parsing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://phabricator.babeljs.io/T7052.
A few things to highlight and I would love to get feedback on for review:
flowandtrailingFunctionCommas. I am therefore not sure if the tests should be placed underbabylonor underbabel-plugin-syntax-trailing-function-commas(or anywhere else)?parseParenAndDistinguishExpression, which is toggled from theflowplugin in casetrailingFunctionCommasis enabled. This is a bit unpleasant because nowtrailingFunctionCommasinfluences theflowplugin. I tried to come up with a way to avoid this new dependency but failed doing so. Is this a problem - and if, is there a better solution?