Don't parse parenthesized string as directive#3220
Merged
sebmck merged 2 commits intobabel:masterfrom Dec 31, 2015
Merged
Conversation
Member
Author
There was a problem hiding this comment.
I assume there's no need to guard against non-existence of extra here ((stmt.expression.extra && ! stmt.expression.extra.parenthesized)).
Contributor
There was a problem hiding this comment.
Tests all pass so should be good.
Current coverage is
|
sebmck
added a commit
that referenced
this pull request
Dec 31, 2015
Don't parse parenthesized string as directive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not a directive:
http://www.ecma-international.org/ecma-262/6.0/#sec-directive-prologues-and-the-use-strict-directive