Force yargs 16/17 to resolve to yargs 18#17988
Merged
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61511 |
|
commit: |
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
If it works I might release the patch as a |
This was referenced May 8, 2026
Merged
JLHwung
approved these changes
May 8, 2026
Contributor
I would say let's wait for yargs team's response. If they explicitly oppose the idea of patch release for old versions, then maybe it is a better time for releasing the patched package. |
liuxingbaoyu
approved these changes
May 9, 2026
JLHwung
pushed a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Jun 8, 2026
* Force yargs 16 to resolve to yargs 17 * Force yargs 17 to resolve to yargs 18 + backwards compat patch # Conflicts: # yarn.lock
JLHwung
added a commit
that referenced
this pull request
Jun 9, 2026
* Test Node.js 26 on CI * Test Node.js 26 on CI * Update node flags list * workaround --------- Co-authored-by: Babel Bot <30521560+liuxingbaoyu@users.noreply.github.com> * Only use realpathSync.native when available * test * Force c8/yargs 17 to resolve to yargs 18 (#17988) * Force yargs 16 to resolve to yargs 17 * Force yargs 17 to resolve to yargs 18 + backwards compat patch # Conflicts: # yarn.lock * ci: bump vue-cli/yargs to ^18.0.0 * ci: run e2e-tests on 7.x branch * debug * Revert "debug" This reverts commit 7b4d605. * workaround extract-zip bug on Node.js 26.1.0 * Revert "test" This reverts commit 39950f6. --------- Co-authored-by: Babel Bot <30521560+liuxingbaoyu@users.noreply.github.com> Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2Node.js 26 breaks (knowingly, so it's not going to be fixed) old versions of Yargs. Let's see if the newer versions are compatible enough that we can just use
resolutions.Ref: yargs/yargs#2509, nodejs/node#62083