test(third-party): parse js defined by // @filename#17922
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61279 |
|
commit: |
nicolo-ribaudo
approved these changes
Apr 17, 2026
nicolo-ribaudo
left a comment
Member
There was a problem hiding this comment.
Nice changes to the allowlist
Member
|
Ughh I just noticed that I accidentally merged this, sorry 😅 The code looked good, and I had also gone through #17904 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
//@filename *.jsIn this PR we improve the ts parser test runner such that it will parse the js files defined by the
@filenamecomment. The motivation here is to reduce the false negative results as TS could throw errors from the js files.This PR includes commits from #17904.