Skip to content

test(parser): use allowlist.md for better DX#17904

Closed
JLHwung wants to merge 2 commits into
babel:mainfrom
JLHwung:parser-test-allowlist-md
Closed

test(parser): use allowlist.md for better DX#17904
JLHwung wants to merge 2 commits into
babel:mainfrom
JLHwung:parser-test-allowlist-md

Conversation

@JLHwung

@JLHwung JLHwung commented Mar 25, 2026

Copy link
Copy Markdown
Contributor
Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

In this PR we propose a format change to the allowlist.txt used in third party parser tests.

The new format allowlist.md is a valid markdown file with the following advantages:

  • It contains the test id and an inner link to the test filename. Contributors can navigate to the test filename directly within the IDE.
  • It supports trailing HTML comments where one can describe why we ignore such tests. Previously the comments are discarded when the allowlist is updated

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Mar 25, 2026
@babel-bot

babel-bot commented Mar 25, 2026

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61276

@JLHwung JLHwung force-pushed the parser-test-allowlist-md branch from d09806c to 029dd67 Compare March 25, 2026 20:29
@pkg-pr-new

pkg-pr-new Bot commented Mar 25, 2026

Copy link
Copy Markdown

Open in StackBlitz

commit: 24106bb

@JLHwung JLHwung requested a review from nicolo-ribaudo March 30, 2026 17:05
@JLHwung

JLHwung commented Apr 17, 2026

Copy link
Copy Markdown
Contributor Author

Closing it as #17922 has been merged, which already includes commits in this PR.

@JLHwung JLHwung closed this Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Internal 🏠 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants