Disallow decorator in array pattern#17159
Merged
JLHwung merged 5 commits intobabel:mainfrom Mar 2, 2025
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58791 |
JLHwung
commented
Mar 2, 2025
| @@ -0,0 +1 @@ | |||
| var [@foo foo ] = foo; | |||
Contributor
Author
There was a problem hiding this comment.
For stage 3 decorators, currently Babel throws a recoverable error message "Decorators cannot be used to decorate parameters.", which is quite confusing. Here we throw an unrecoverable error since we already do that for object patterns.
d2701df to
eda0d82
Compare
liuxingbaoyu
approved these changes
Mar 2, 2025
nicolo-ribaudo
approved these changes
Mar 2, 2025
laine-hallot
pushed a commit
to laine-hallot/uwu-parser
that referenced
this pull request
Mar 31, 2025
* type cleanup * fix: disallow decorator in array pattern * copy test cases to stage 3 decorators * rename parseAssignableListItem to parseBindingElement * incorrect test setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
var [@foo foo ] = foo;as decorator within an array pattern, which is not allowed.Spot this issue when browsing through the
lvalimplementation.