[Babel 8] Create TSTemplateLiteralType#17066
Merged
JLHwung merged 11 commits intobabel:mainfrom Jan 27, 2025
Merged
Conversation
11 tasks
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58621 |
JLHwung
commented
Jan 16, 2025
| rm tests/format/typescript/typeparams/consistent/format.test.js | ||
| rm tests/format/typescript/template-literal-types/format.test.js | ||
| rm tests/format/typescript/method/format.test.js | ||
| rm tests/format/typescript/argument-expansion/format.test.js |
Contributor
Author
There was a problem hiding this comment.
/cc @fisker These tests are affected by this breaking change.
877427a to
5400a2d
Compare
JLHwung
commented
Jan 17, 2025
| export interface TsTemplateLiteralType extends TsTypeBase { | ||
| type: "TSTemplateLiteralType"; | ||
| quasis: TemplateElement[]; | ||
| expressions: TsType[]; |
Contributor
Author
There was a problem hiding this comment.
I overlooked that TSTemplateLiteralType uses types here. I will update the AST and the generator methods.
a5010ee to
cd7b11e
Compare
Since the generator requires the types information
Comment on lines
+501
to
+520
| export function TSTemplateLiteralType( | ||
| this: Printer, | ||
| node: t.TSTemplateLiteralType, | ||
| ) { | ||
| const quasis = node.quasis; | ||
|
|
||
| let partRaw = "`"; | ||
|
|
||
| for (let i = 0; i < quasis.length; i++) { | ||
| partRaw += quasis[i].value.raw; | ||
|
|
||
| if (i + 1 < quasis.length) { | ||
| this.token(partRaw + "${", true); | ||
| this.print(node.types[i]); | ||
| partRaw = "}"; | ||
| } | ||
| } | ||
|
|
||
| this.token(partRaw + "`", true); | ||
| } |
Member
There was a problem hiding this comment.
We can extract this to a function _printTemplate(quasis, substitutions), so that we don't have to keep the same logic in two different printers.
nicolo-ribaudo
approved these changes
Jan 20, 2025
Contributor
Author
|
Pushed a ranges fix in the |
Member
|
|
Contributor
Author
Good question. Yes it can still contain a |
liuxingbaoyu
approved these changes
Jan 24, 2025
laine-hallot
pushed a commit
to laine-hallot/uwu-parser
that referenced
this pull request
Mar 31, 2025
* breaking: create TSTemplateLiteralType * update test fixtures * ignore TSTemplateLiteralType in printer test * purge failing prettier tests * rename expressions to types * fix: generate TSLiteralType when the template does not contain types * restore template literals transform * update test fixtures * define TSTemplateLiteralType for Babel 7 Since the generator requires the types information * refactor: extract _printTemplate helper * Apply template literal range fixes to TSTemplateLiteralType
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we generate the
TSTemplateLiteralTypeAST node when there is at least onetypeelement (${...}) within the template.