Allow sync loading of ESM when `--experimental-require-module` by nicolo-ribaudo · Pull Request #16820 · babel/babel

nicolo-ribaudo · 2024-09-08T17:56:34Z

Q	A
Fixed Issues?	`Fixes #1, Fixes #2`
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

Node.js now has this flag to allow require() of ESM files, which means we can support ESM plugins/presets in transformSync&co. This will be useful for the Babel 8 migration.

This PR simply makes us respect that Node.js flag rather than just refusing to require() esm files ending in .mjs. I'm not sure if I should consider it as a bugfix or as internal. Note that require("<something>.js") already worked for ESM under that flag, because we try/catch to see if the .js file can be loaded.

babel-bot · 2024-09-08T17:58:22Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57998

nicolo-ribaudo · 2024-09-17T07:29:09Z

This is not breaking but I'd like to get it merged before the 8.0.0-beta, since it significantly simplify using ESM plugins (i.e. you wouldn't be forced to use Babel asynchronously anymore).

liuxingbaoyu · 2024-09-17T17:30:45Z

packages/babel-core/src/config/files/module-types.ts

 export default function* loadCodeDefault(
  filepath: string,
-  asyncError: string,
+  loader: "require" | "import" | "auto",


auto doesn't seem to be used?

nicolo-ribaudo · 2024-09-26T16:43:36Z

This flag will be unflagged in Node.js 23.

liuxingbaoyu

Amazing!

@JLHwung

##### [`v7.25.7](https://github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7257-2024-10-02) ##### 🐛 Bug Fix - `babel-helper-validator-identifier` - [#16825](babel/babel#16825) fix: update identifier to unicode 16 ([@JLHwung](https://github.com/JLHwung)) - `babel-traverse` - [#16814](babel/babel#16814) fix: issue with node path keys updated on unrelated paths ([@DylanPiercey](https://github.com/DylanPiercey)) - `babel-plugin-transform-classes` - [#16797](babel/babel#16797) Use an inclusion rather than exclusion list for `super()` check ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-generator` - [#16788](babel/babel#16788) Fix printing of TS `infer` in compact mode ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - [#16785](babel/babel#16785) Print TS type annotations for destructuring in assignment pattern ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - [#16778](babel/babel#16778) Respect `[no LineTerminator here]` after nodes ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) ##### 💅 Polish - `babel-types` - [#16852](babel/babel#16852) Add deprecated JSDOC for fields ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) ##### 🏠 Internal - `babel-core` - [#16820](babel/babel#16820) Allow sync loading of ESM when `--experimental-require-module` ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-helper-compilation-targets`, `babel-helper-plugin-utils`, `babel-preset-env` - [#16858](babel/babel#16858) Add browserslist config to external dependency ([@JLHwung](https://github.com/JLHwung)) - `babel-plugin-proposal-destructuring-private`, `babel-plugin-syntax-decimal`, `babel-plugin-syntax-import-reflection`, `babel-standalone` - [#16809](babel/babel#16809) Archive syntax-import-reflection and syntax-decimal ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-generator` - [#16779](babel/babel#16779) Simplify logic for `[no LineTerminator here]` before nodes ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) ##### 🏃‍♀️ Performance - `babel-plugin-transform-typescript` - [#16875](babel/babel#16875) perf: Avoid extra cloning of namespaces ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-types` - [#16842](babel/babel#16842) perf: Improve [@babel/types](https://github.com/babel/types) builders ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - [#16828](babel/babel#16828) Only access `BABEL_TYPES_8_BREAKING` at startup ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo))

@JLHwung

##### [`v7.25.7](https://github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7257-2024-10-02) ##### 🐛 Bug Fix - `babel-helper-validator-identifier` - [#16825](babel/babel#16825) fix: update identifier to unicode 16 ([@JLHwung](https://github.com/JLHwung)) - `babel-traverse` - [#16814](babel/babel#16814) fix: issue with node path keys updated on unrelated paths ([@DylanPiercey](https://github.com/DylanPiercey)) - `babel-plugin-transform-classes` - [#16797](babel/babel#16797) Use an inclusion rather than exclusion list for `super()` check ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-generator` - [#16788](babel/babel#16788) Fix printing of TS `infer` in compact mode ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - [#16785](babel/babel#16785) Print TS type annotations for destructuring in assignment pattern ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - [#16778](babel/babel#16778) Respect `[no LineTerminator here]` after nodes ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) ##### 💅 Polish - `babel-types` - [#16852](babel/babel#16852) Add deprecated JSDOC for fields ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) ##### 🏠 Internal - `babel-core` - [#16820](babel/babel#16820) Allow sync loading of ESM when `--experimental-require-module` ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-helper-compilation-targets`, `babel-helper-plugin-utils`, `babel-preset-env` - [#16858](babel/babel#16858) Add browserslist config to external dependency ([@JLHwung](https://github.com/JLHwung)) - `babel-plugin-proposal-destructuring-private`, `babel-plugin-syntax-decimal`, `babel-plugin-syntax-import-reflection`, `babel-standalone` - [#16809](babel/babel#16809) Archive syntax-import-reflection and syntax-decimal ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-generator` - [#16779](babel/babel#16779) Simplify logic for `[no LineTerminator here]` before nodes ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) ##### 🏃‍♀️ Performance - `babel-plugin-transform-typescript` - [#16875](babel/babel#16875) perf: Avoid extra cloning of namespaces ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-types` - [#16842](babel/babel#16842) perf: Improve [@babel/types](https://github.com/babel/types) builders ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - [#16828](babel/babel#16828) Only access `BABEL_TYPES_8_BREAKING` at startup ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo))

victordidenko · 2024-10-07T09:59:08Z

I'm not sure, but looks like this change breaks something, I'm receiving error

[!] (plugin wyw-in-js) Error: [BABEL] src/index.ts: .loader is not a valid Plugin property
src/index.ts
    at .../node_modules/.pnpm/@babel+core@7.25.7/node_modules/@babel/core/src/config/validation/plugins.ts:122:41
    at Array.forEach (<anonymous>)
    at validatePluginObject (.../node_modules/.pnpm/@babel+core@7.25.7/node_modules/@babel/core/src/config/validation/plugins.ts:108:20)

Or maybe this is an issue with Anber/wyw-in-js#104

nicolo-ribaudo · 2024-10-07T21:58:03Z

Could you open a new issue? This is indeed a regression, I didn't realize that that API is public.

victordidenko · 2024-10-08T12:36:06Z

opened 👌

nicolo-ribaudo added the pkg: core label Sep 8, 2024

nicolo-ribaudo force-pushed the require-esm branch 2 times, most recently from b90eb37 to 2980b50 Compare September 16, 2024 11:57

nicolo-ribaudo added this to the v8.0.0-beta milestone Sep 17, 2024

nicolo-ribaudo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Sep 17, 2024

liuxingbaoyu reviewed Sep 17, 2024

View reviewed changes

nicolo-ribaudo added 6 commits September 23, 2024 15:58

Allow sync loading of ESM when --experimental-require-module

4847c20

Fixes

f4677ef

fix

6ef32ee

Always prefer require() for .js

2f52b88

Test needs ESM support

cd2de04

Unify auto and import

ea3eb8b

nicolo-ribaudo force-pushed the require-esm branch from 1a58491 to ea3eb8b Compare September 23, 2024 14:13

liuxingbaoyu approved these changes Sep 26, 2024

View reviewed changes

JLHwung approved these changes Sep 26, 2024

View reviewed changes

nicolo-ribaudo merged commit b2ba04c into babel:main Sep 26, 2024

nicolo-ribaudo deleted the require-esm branch September 26, 2024 17:48

yume-chan mentioned this pull request Oct 4, 2024

Stopped working with @babel/core 7.25.7 Anber/wyw-in-js#104

Closed

davidjbradshaw mentioned this pull request Oct 6, 2024

[Snyk] Upgrade @babel/runtime from 7.25.6 to 7.25.7 davidjbradshaw/iframe-resizer#1346

Closed

victordidenko mentioned this pull request Oct 8, 2024

[Bug]: Plugin config validation issue #16887

Closed

1 task

NOUIY mentioned this pull request Oct 23, 2024

[Snyk] Upgrade @babel/core from 7.17.9 to 7.25.7 NOUIY/angular#807

Open

nerdy-tech-com-gitub mentioned this pull request Oct 24, 2024

[Snyk] Upgrade @babel/parser from 7.1.3 to 7.25.7 nerdy-tech-com-gitub/node#10

Open

tiff-es mentioned this pull request Nov 10, 2024

[Snyk] Upgrade @babel/preset-env from 7.4.5 to 7.25.8 tiff-es/fewpjs-getter-and-setter-methods-dc-web-091619#272

Open

This was referenced Nov 11, 2024

[Snyk] Upgrade @babel/core from 7.14.3 to 7.25.8 i3-Market-V3-Public-Repository/Support---Deployment-Tools#75

Open

[Snyk] Upgrade @babel/preset-env from 7.14.4 to 7.25.8 i3-Market-V3-Public-Repository/Support---Deployment-Tools#76

Open

This was referenced Nov 12, 2024

[Snyk] Upgrade @babel/core from 7.4.5 to 7.25.8 nejidevelops/phase-1-domcontentloaded#115

Open

[Snyk] Upgrade @babel/preset-env from 7.4.5 to 7.25.8 nejidevelops/phase-1-domcontentloaded#116

Open

DevangPatelUK mentioned this pull request Nov 12, 2024

[Snyk] Upgrade @babel/runtime from 7.17.2 to 7.25.9 DevangPatelUK/BotFramework-WebChat#517

Open

This was referenced Nov 12, 2024

[Snyk] Upgrade @babel/core from 7.18.2 to 7.25.9 nejidevelops/phase-0-intro-to-js-2-objects-lab#111

Open

[Snyk] Upgrade @babel/preset-env from 7.18.2 to 7.25.9 nejidevelops/phase-0-intro-to-js-2-objects-lab#112

Open

ali8889 mentioned this pull request Nov 13, 2024

[Snyk] Upgrade @babel/runtime from 7.0.0-beta.42 to 7.25.9 ali8889/mist#667

Open

sebastianthulin mentioned this pull request Nov 13, 2024

[Snyk] Upgrade @babel/plugin-transform-runtime from 7.25.7 to 7.25.9 helsingborg-stad/Municipio#1126

Merged

maismas mentioned this pull request Nov 13, 2024

[Snyk] Upgrade @babel/runtime from 7.25.7 to 7.25.9 snyk/sweater-comb#667

Merged

NOUIY mentioned this pull request Nov 13, 2024

[Snyk] Upgrade @babel/core from 7.17.9 to 7.25.9 NOUIY/angular#810

Open

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 8, 2025

github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Allow sync loading of ESM when `--experimental-require-module`#16820

Allow sync loading of ESM when `--experimental-require-module`#16820
nicolo-ribaudo merged 6 commits intobabel:mainfrom
nicolo-ribaudo:require-esm

nicolo-ribaudo commented Sep 8, 2024

Uh oh!

babel-bot commented Sep 8, 2024 •

edited

Loading

Uh oh!

nicolo-ribaudo commented Sep 17, 2024

Uh oh!

liuxingbaoyu Sep 17, 2024 •

edited

Loading

Uh oh!

nicolo-ribaudo commented Sep 26, 2024

Uh oh!

liuxingbaoyu left a comment

Uh oh!

victordidenko commented Oct 7, 2024

Uh oh!

nicolo-ribaudo commented Oct 7, 2024

Uh oh!

victordidenko commented Oct 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

nicolo-ribaudo commented Sep 8, 2024

Uh oh!

babel-bot commented Sep 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolo-ribaudo commented Sep 17, 2024

Uh oh!

liuxingbaoyu Sep 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicolo-ribaudo commented Sep 26, 2024

Uh oh!

liuxingbaoyu left a comment

Choose a reason for hiding this comment

Uh oh!

victordidenko commented Oct 7, 2024

Uh oh!

nicolo-ribaudo commented Oct 7, 2024

Uh oh!

victordidenko commented Oct 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

babel-bot commented Sep 8, 2024 •

edited

Loading

liuxingbaoyu Sep 17, 2024 •

edited

Loading