Move all runtime helpers to individual files by nicolo-ribaudo · Pull Request #16495 · babel/babel

nicolo-ribaudo · 2024-05-15T12:43:19Z

Q	A
Fixed Issues?	`Fixes #1, Fixes #2`
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

After this PR, since there is a build step for all helpers, I plan to move

babel/packages/babel-helpers/src/index.ts

Line 42 in 6e3539b

function getHelperMetadata(file: File): HelperMetadata {

to be done at build-time rather than at runtime.

This PR caught a problem with our Babel7/8 integration tests: some tests fail because the helpers are missing (for example, old decorator helpers), but we didn't notice because we where generating those helpers even in Babel 8 mode during the test.

nicolo-ribaudo · 2024-05-15T12:43:55Z

packages/babel-runtime/package.json

      "./helpers/AsyncGenerator.js"
    ],
    "./helpers/esm/AsyncGenerator": "./helpers/esm/AsyncGenerator.js",
+    "./helpers/AwaitValue": [


These package.json files are now just sorted alphabetically, but the contents are the same.

babel-bot · 2024-05-15T12:45:28Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56904

…defined")

This reverts commit b98b0dc.

liuxingbaoyu

Maybe it would be better to keep Object.freeze(helpers)?

nicolo-ribaudo · 2024-05-16T10:47:19Z

In tests we mutate the helpers object to add fake helpers, so unfortunately it doesn't work. The final helpers object was already unfrozen, because we spread the frozen object into a non-frozen one.

nicolo-ribaudo · 2024-05-16T13:32:21Z

I'll open a good first issue to convert the helpers to TS (in chunks)

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@babel/traverse](https://babel.dev/docs/en/next/babel-traverse) ([source](https://github.com/babel/babel)) | resolutions | patch | [`7.24.1` -> `7.24.7`](https://renovatebot.com/diffs/npm/@babel%2ftraverse/7.24.1/7.24.7) | --- ### Release Notes <details> <summary>babel/babel (@babel/traverse)</summary> ### [`v7.24.7`](https://github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7247-2024-06-05) [Compare Source](babel/babel@v7.24.6...v7.24.7) ##### 🐛 Bug Fix - `babel-node` - [#16554](babel/babel#16554) Allow extra flags in babel-node ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-traverse` - [#16522](babel/babel#16522) fix: incorrect `constantViolations` with destructuring ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-helper-transform-fixture-test-runner`, `babel-plugin-proposal-explicit-resource-management` - [#16524](babel/babel#16524) fix: Transform `using` in `switch` correctly ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) ##### 🏠 Internal - `babel-helpers`, `babel-runtime-corejs2`, `babel-runtime-corejs3`, `babel-runtime` - [#16525](babel/babel#16525) Delete unused array helpers ([@blakewilson](https://github.com/blakewilson)) ### [`v7.24.6`](https://github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7246-2024-05-24) [Compare Source](babel/babel@v7.24.5...v7.24.6) ##### 🐛 Bug Fix - `babel-helper-create-class-features-plugin`, `babel-plugin-transform-class-properties` - [#16514](babel/babel#16514) Fix source maps for private member expressions ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-core`, `babel-generator`, `babel-plugin-transform-modules-commonjs` - [#16515](babel/babel#16515) Fix source maps for template literals ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-helper-create-class-features-plugin`, `babel-plugin-proposal-decorators` - [#16485](babel/babel#16485) Support undecorated static accessor in anonymous classes ([@JLHwung](https://github.com/JLHwung)) - [#16484](babel/babel#16484) Fix decorator bare yield await ([@JLHwung](https://github.com/JLHwung)) - `babel-helpers`, `babel-plugin-proposal-decorators`, `babel-runtime-corejs3` - [#16483](babel/babel#16483) Fix: throw TypeError if addInitializer is called after finished ([@JLHwung](https://github.com/JLHwung)) - `babel-parser`, `babel-plugin-transform-typescript` - [#16476](babel/babel#16476) fix: Correctly parse `cls.fn<C> = x` ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) ##### 🏠 Internal - `babel-core`, `babel-helpers`, `babel-plugin-transform-runtime`, `babel-preset-env`, `babel-runtime-corejs2`, `babel-runtime-corejs3`, `babel-runtime` - [#16501](babel/babel#16501) Generate helper metadata at build time ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-helpers` - [#16499](babel/babel#16499) Add `tsconfig.json` for `@babel/helpers/src/helpers` ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-cli`, `babel-helpers`, `babel-plugin-external-helpers`, `babel-plugin-proposal-decorators`, `babel-plugin-transform-class-properties`, `babel-plugin-transform-modules-commonjs`, `babel-plugin-transform-modules-systemjs`, `babel-plugin-transform-runtime`, `babel-preset-env`, `babel-runtime-corejs2`, `babel-runtime-corejs3`, `babel-runtime` - [#16495](babel/babel#16495) Move all runtime helpers to individual files ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-parser`, `babel-traverse` - [#16482](babel/babel#16482) Statically generate boilerplate for bitfield accessors ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - Other - [#16466](babel/babel#16466) Migrate import assertions syntax ([@JLHwung](https://github.com/JLHwung)) ### [`v7.24.5`](https://github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7245-2024-04-29) [Compare Source](babel/babel@v7.24.1...v7.24.5) ##### 🐛 Bug Fix - `babel-plugin-transform-classes`, `babel-traverse` - [#16377](babel/babel#16377) fix: TypeScript annotation affects output ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-helpers`, `babel-plugin-proposal-explicit-resource-management`, `babel-runtime-corejs3` - [#16440](babel/babel#16440) Fix suppressed error order ([@sossost](https://github.com/sossost)) - [#16408](babel/babel#16408) Await nullish async disposable ([@JLHwung](https://github.com/JLHwung)) ##### 💅 Polish - `babel-parser` - [#16407](babel/babel#16407) Recover from exported `using` declaration ([@JLHwung](https://github.com/JLHwung)) ##### 🏠 Internal - Other - [#16414](babel/babel#16414) Relax ESLint peerDependency constraint to allow v9 ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-parser` - [#16425](babel/babel#16425) Improve `@babel/parser` AST types ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - [#16417](babel/babel#16417) Always pass type argument to `.startNode` ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-helper-create-class-features-plugin`, `babel-helper-member-expression-to-functions`, `babel-helper-module-transforms`, `babel-helper-split-export-declaration`, `babel-helper-wrap-function`, `babel-helpers`, `babel-plugin-bugfix-firefox-class-in-computed-class-key`, `babel-plugin-proposal-explicit-resource-management`, `babel-plugin-transform-block-scoping`, `babel-plugin-transform-destructuring`, `babel-plugin-transform-object-rest-spread`, `babel-plugin-transform-optional-chaining`, `babel-plugin-transform-parameters`, `babel-plugin-transform-private-property-in-object`, `babel-plugin-transform-react-jsx-self`, `babel-plugin-transform-typeof-symbol`, `babel-plugin-transform-typescript`, `babel-traverse` - [#16439](babel/babel#16439) Make `NodePath<T | U>` distributive ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-plugin-proposal-partial-application`, `babel-types` - [#16421](babel/babel#16421) Remove `JSXNamespacedName` from valid `CallExpression` args ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-plugin-transform-class-properties`, `babel-preset-env` - [#16406](babel/babel#16406) Do not load unnecessary Babel 7 syntax plugins in Babel 8 ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) ##### 🏃‍♀️ Performance - `babel-helpers`, `babel-preset-env`, `babel-runtime-corejs3` - [#16357](babel/babel#16357) Performance: improve `objectWithoutPropertiesLoose` on V8 ([@romgrk](https://github.com/romgrk)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.vylpes.xyz/RabbitLabs/random-bunny/pulls/173 Co-authored-by: Renovate Bot <renovate@vylpes.com> Co-committed-by: Renovate Bot <renovate@vylpes.com>

nicolo-ribaudo added 3 commits May 15, 2024 14:29

Move all runtime helpers to individual files

75e77e7

Regenerate babel-runtime

01377b7

Update fixtures

557da44

nicolo-ribaudo added the PR: Internal 🏠 A type of pull request used for our changelog categories label May 15, 2024

nicolo-ribaudo commented May 15, 2024

View reviewed changes

nicolo-ribaudo added the area: helpers label May 15, 2024

nicolo-ribaudo added 2 commits May 15, 2024 15:19

Make errors for bugs in helpers more helpful (and not "this.hub is un…

dac7164

…defined")

Wrap Babel 7 helpers in !BABEL_8_BREAKING

518f46d

nicolo-ribaudo force-pushed the helpers-refactor branch 2 times, most recently from cf1de47 to 624ef72 Compare May 15, 2024 15:55

nicolo-ribaudo added 2 commits May 15, 2024 18:34

Skip failing decorators tests in Babel7/8

24d341d

Disable most CI

b98b0dc

nicolo-ribaudo force-pushed the helpers-refactor branch from 624ef72 to b98b0dc Compare May 15, 2024 16:35

nicolo-ribaudo added 3 commits May 15, 2024 18:49

Skip failing Babel 7 old class helpers test in Babel 8

223b03a

Use latest decorators version in metadata test

1f3a831

Revert "Disable most CI"

be734ba

This reverts commit b98b0dc.

liuxingbaoyu approved these changes May 16, 2024

View reviewed changes

JLHwung approved these changes May 16, 2024

View reviewed changes

nicolo-ribaudo merged commit db3e9a6 into babel:main May 16, 2024

nicolo-ribaudo deleted the helpers-refactor branch May 16, 2024 13:32

nicolo-ribaudo mentioned this pull request May 16, 2024

Convert remaning runtime helpers to TypeScript #16500

Closed

13 tasks

teramotodaiki mentioned this pull request Jun 10, 2024

[Snyk] Upgrade @babel/runtime from 7.24.6 to 7.24.7 hackforplay/common#225

Closed

nejidevelops mentioned this pull request Jun 14, 2024

[Snyk] Upgrade: , nejidevelops/phase-1-destructuring-assignment#37

Open

NOUIY mentioned this pull request Jun 14, 2024

[Snyk] Upgrade @babel/core from 7.17.9 to 7.24.6 NOUIY/angular#756

Open

This was referenced Jun 14, 2024

[Snyk] Upgrade: , nejidevelops/phase-1-domcontentloaded#35

Open

[Snyk] Upgrade: , nejidevelops/phase-0-intro-to-js-2-looping-code-along#36

Open

richyhoopd mentioned this pull request Aug 13, 2024

[Snyk] Upgrade: , , richyhoopd/RichyFlix#904

Open

nejidevelops mentioned this pull request Aug 14, 2024

[Snyk] Upgrade: , nejidevelops/phase-1-destructuring-assignment#49

Open

hashim21223445 mentioned this pull request Aug 14, 2024

[Snyk] Upgrade: , , hashim21223445/eslint-config-prettier#16

Open

This was referenced Aug 14, 2024

[Snyk] Upgrade: , tiff-es/fewpjs-acting-on-events-dc-web-091619#202

Open

[Snyk] Upgrade: , tiff-es/js-data-structures-objects-lab-dc-web-091619#199

Open

satoshinakamoto007 mentioned this pull request Aug 14, 2024

[Snyk] Upgrade: , , , satoshinakamoto007/docs#842

Open

denis-snyk mentioned this pull request Aug 14, 2024

[Snyk] Upgrade: , , snyk/vscode-extension#514

Closed

aassaa110012 mentioned this pull request Aug 15, 2024

[Snyk] Upgrade @babel/core from 7.12.3 to 7.24.9 aassaa110012/ocis#2

Open

This was referenced Aug 15, 2024

[Snyk] Upgrade: , tiff-es/fewpjs-fns-as-first-class-data-do-behavior-dc-web-091619#200

Open

[Snyk] Upgrade: , tiff-es/fewpjs-adding-behavior-with-methods-dc-web-091619#219

Open

DevangPatelUK mentioned this pull request Aug 15, 2024

[Snyk] Upgrade @babel/runtime from 7.19.0 to 7.24.8 DevangPatelUK/BotFramework-WebChat#134

Open

AnushaSalian mentioned this pull request Aug 15, 2024

[Snyk] Upgrade: , virtual-labs/ph3-lab-mgmt#505

Open

x-way mentioned this pull request Aug 15, 2024

[Snyk] Upgrade @babel/preset-env from 7.24.0 to 7.24.8 x-way/cal-heatmap#547

Closed

This was referenced Aug 16, 2024

[Snyk] Upgrade: , tiff-es/fewpjs-fns-as-first-class-data-do-behavior-dc-web-091619#201

Open

[Snyk] Upgrade: , tiff-es/fewpjs-fns-as-first-class-data-array-o-functions-dc-web-091619#210

Open

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 16, 2024

github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Move all runtime helpers to individual files#16495

Move all runtime helpers to individual files#16495
nicolo-ribaudo merged 10 commits intobabel:mainfrom
nicolo-ribaudo:helpers-refactor

nicolo-ribaudo commented May 15, 2024 •

edited

Loading

Uh oh!

nicolo-ribaudo May 15, 2024

Uh oh!

babel-bot commented May 15, 2024 •

edited

Loading

Uh oh!

liuxingbaoyu left a comment

Uh oh!

nicolo-ribaudo commented May 16, 2024

Uh oh!

nicolo-ribaudo commented May 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

nicolo-ribaudo commented May 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolo-ribaudo May 15, 2024

Choose a reason for hiding this comment

Uh oh!

babel-bot commented May 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liuxingbaoyu left a comment

Choose a reason for hiding this comment

Uh oh!

nicolo-ribaudo commented May 16, 2024

Uh oh!

nicolo-ribaudo commented May 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nicolo-ribaudo commented May 15, 2024 •

edited

Loading

babel-bot commented May 15, 2024 •

edited

Loading