Skip to content

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Feb 16, 2024

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

In this PR we add a new class replacement test. It seems that the this value of initializers in a decorated class are not covered in other tests.

Copy link
Member

@liuxingbaoyu liuxingbaoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JLHwung JLHwung merged commit b36fdfc into babel:feat-7.24.0/decorators Feb 16, 2024
@JLHwung JLHwung deleted the add-class-replacement-test branch February 16, 2024 18:13
@dec
class Foo {
@(captureInitializerThis(v => accessorThis = v))
static accessor;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, merged too early, it should have been static accessor accessor.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I committed this change at #16287. :)

liuxingbaoyu pushed a commit to liuxingbaoyu/babel that referenced this pull request Mar 5, 2024
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue Spec: Decorators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants