Improve plugins typings (Part 2) by JLHwung · Pull Request #14639 · babel/babel

JLHwung · 2022-06-04T21:25:43Z

Q	A
License	MIT

See #14601 for more info. This PR can be reviewed by commits: each of them deal with a single plugin.

packages/babel-plugin-transform-block-scoping/src/index.ts

babel-bot · 2022-06-04T21:28:22Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52162/

nicolo-ribaudo · 2022-06-05T05:51:06Z

packages/babel-helper-builder-binary-assignment-operator-visitor/src/index.ts

+export default function (opts: {
+  build: (
+    left: t.Expression | t.PrivateName,
+    right: t.BinaryExpression["right"],


Isn't this just t.Expression?

👍 Yes it is. I tried lowering left to t.Expression when operator is not in but failed.

nicolo-ribaudo · 2022-06-05T05:52:54Z

packages/babel-plugin-transform-computed-properties/src/index.ts

+            prop.computed || t.isLiteral(prop.key),
          ),
+          // @ts-expect-error todo(flow->ts): double-check type error
+          getValue(prop),


Q: what is the error here?

getValue returns the value of ObjectProperty, which contains Pattern elements. It should be fixed in getValue then.

nicolo-ribaudo · 2022-06-05T05:53:45Z

packages/babel-plugin-transform-computed-properties/src/index.ts


-  function pushAssign(objId, prop, body) {
-    if (prop.kind === "get" && prop.kind === "set") {
-      pushMutatorDefine(objId, prop);


Note for reviewers: moved to pushComputedPropsLoose.

nicolo-ribaudo · 2022-06-05T05:57:12Z

packages/babel-plugin-transform-block-scoping/src/index.ts

+      callPath =
+        parentPath.get(listKey)[
+          // @ts-ignore
+          key + index


We can cast key to a number, since it's in a list container.

liuxingbaoyu

This looks fine to me, but since I'm not familiar with plugins it's likely that I'm overlooking something.

* exponentiation-operator * duplicate-keys * computed-properties * replace-supers * block-scoping * block-scoped-functions * syntax-typescript * record-and-tuple * private-property-in-object * partial-application * json-strings * function-sent * function-bind * class-static-block * async-generator-functions * Update packages/babel-plugin-transform-block-scoping/src/index.ts * address review comments * helper-replace-supers

* enable noImplicitAny * codemod (#14602) * Improve preset/plugin-typescript typings (#14603) * preset-typescript * transform-typescript * Update packages/babel-plugin-transform-typescript/src/enum.ts Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * prettier Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * Improve transform-runtime typings (#14605) * enable noImplicitAny * codemod (#14602) * Improve preset/plugin-typescript typings (#14603) * preset-typescript * transform-typescript * Update packages/babel-plugin-transform-typescript/src/enum.ts Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * prettier Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * improve transform-runtime typings Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * jsx (#14607) * Improve module transform packages typings (#14608) * improve babel-template typings (#14621) * Improve @babel/helper-* typings (#14620) * improve helper-function-name typings * helper hoist variables * helper-member-expression-to-functions * helper-simple-access * remap-async-to-generator * helper-annotate-as-pure * helper-builder-binary-assignment-operator-visitor * helper-check-duplicate-nodes * early return when export declaration is export all * split-export-declaration * helper-define-map * define-map * Update packages/babel-helper-builder-binary-assignment-operator-visitor/src/index.ts Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * review comments Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * improve helper-module-imports typings (#14623) * refactor: simplify ImportInjector._applyDefaults * helper-module-imports * map globals to the one used in Babel 8 * Improve fixture-test-runner typings (#14625) * plugin-test-runner * fixture-test-runner * Update packages/babel-helper-fixtures/src/index.ts Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * Improve preset-env typings (#14606) * refactor: move shipped-proposals to ts * preset-env * address review comments * Improve pipeline-operator typings (#14629) * refactor: simplify buildOptimizedSequenceExpression * proposal-pipeline-operator * address review comments * improve standalone typings (#14630) * babel-standalone * address review comment * Improve plugins typings (Part 1) (#14633) * change AssumptionFunction return type * helper-create-regexp-features-plugin * create-class-features-plugin * transform-for-of * improve unicode-escapes typings * transform-object-super * transform-react-constant-elements * proto-to-assign * function-name * flow-comments TS cannot infer Flow visitor type because we have both Flow type and Flow virtual type. * Improve code-frame/hightlight typings (#14643) * code-frame * map js-tokens to Babel 8 * highlight * Improve `@babel/types` typings (#14645) * bump to-fast-properties to v4 * types * mark node comments as mutable * Improve babel-core typings (#14622) Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * improve transform-classes typings (#14624) * Improve `@babel/generator` typings (#14644) * generator * refactor: merge {start,end}Terminatorless to printTerminatorless * inline buildYieldAwait * inline ExportDeclaration * also export Pos * let getPossibleRaw return string | void * Apply suggestions from code review Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> Co-authored-by: liuxingbaoyu <30521560+liuxingbaoyu@users.noreply.github.com> * address review comments * do not export internal printer method * simplify needsWhitespace Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> Co-authored-by: liuxingbaoyu <30521560+liuxingbaoyu@users.noreply.github.com> * Improve plugins typings (Part 2) (#14639) * exponentiation-operator * duplicate-keys * computed-properties * replace-supers * block-scoping * block-scoped-functions * syntax-typescript * record-and-tuple * private-property-in-object * partial-application * json-strings * function-sent * function-bind * class-static-block * async-generator-functions * Update packages/babel-plugin-transform-block-scoping/src/index.ts * address review comments * helper-replace-supers * Improve plugins typings (Part 3) (#14642) * external-helpers * bugfix * transform-parameters * object-rest-spread * destructuring-private * transform-destructuring * proposal-decorators * optional-chaining * helper-wrap-function * explode-assignable-expression * helper-compilation-targets * helper-plugin-utils * helpers * helper-validator-option * fix: allow "+" and "-" in MappedType .readonly/.optional * fixture-test-runner * remove charcodes from dependencies the charcodes transform will inline charCodes.* so we can remove it from dependencies * Improve traverse typings (#14648) * export removeProperties options * traverse * fix other packages typings * fix gatherNodeParts * downgrade to-fast-properties to v3 * fix typo * babel-core/normalize-file * add ignore comment property used by flow plugin * refine getLastStatement typings * fix babel-standalone rebase typing error * fix assert.rejects polyfill * simplify _param typings * supress Babel 7 AST errors * loosen defineType typings The AST typings are generated from defineType calls, so defineType should accept a string as type. * restore legacy code * Suppress data/core-js-compat importing errors Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> Co-authored-by: liuxingbaoyu <30521560+liuxingbaoyu@users.noreply.github.com>

JLHwung added 15 commits June 4, 2022 17:17

exponentiation-operator

b48b46d

duplicate-keys

951254b

computed-properties

4003fa3

replace-supers

f5165b2

block-scoping

60d5844

block-scoped-functions

d49cc57

syntax-typescript

2b4bb62

record-and-tuple

bc18c01

private-property-in-object

28eadbb

partial-application

043a289

json-strings

e70bca5

function-sent

e0fc2b4

function-bind

75e7ed1

class-static-block

ae3b18b

async-generator-functions

4eeaa37

JLHwung commented Jun 4, 2022

View reviewed changes

packages/babel-plugin-transform-block-scoping/src/index.ts Outdated Show resolved Hide resolved

nicolo-ribaudo approved these changes Jun 5, 2022

View reviewed changes

JLHwung added 3 commits June 6, 2022 09:24

Update packages/babel-plugin-transform-block-scoping/src/index.ts

ab68f2d

address review comments

0054372

helper-replace-supers

3b0c873

liuxingbaoyu approved these changes Jun 18, 2022

View reviewed changes

JLHwung merged commit 0d7a7ef into babel:noImplicitAny Jun 18, 2022

JLHwung deleted the noImplictAny-plugins-2 branch June 18, 2022 20:18

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 18, 2022

github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improve plugins typings (Part 2)#14639

Improve plugins typings (Part 2)#14639
JLHwung merged 18 commits intobabel:noImplicitAnyfrom
JLHwung:noImplictAny-plugins-2

JLHwung commented Jun 4, 2022 •

edited by gitpod-io bot

Loading

Uh oh!

Uh oh!

babel-bot commented Jun 4, 2022 •

edited

Loading

Uh oh!

nicolo-ribaudo Jun 5, 2022

Uh oh!

JLHwung Jun 6, 2022

Uh oh!

nicolo-ribaudo Jun 5, 2022

Uh oh!

JLHwung Jun 6, 2022

Uh oh!

nicolo-ribaudo Jun 5, 2022 •

edited

Loading

Uh oh!

nicolo-ribaudo Jun 5, 2022

Uh oh!

liuxingbaoyu left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

JLHwung commented Jun 4, 2022 • edited by gitpod-io bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

babel-bot commented Jun 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolo-ribaudo Jun 5, 2022

Choose a reason for hiding this comment

Uh oh!

JLHwung Jun 6, 2022

Choose a reason for hiding this comment

Uh oh!

nicolo-ribaudo Jun 5, 2022

Choose a reason for hiding this comment

Uh oh!

JLHwung Jun 6, 2022

Choose a reason for hiding this comment

Uh oh!

nicolo-ribaudo Jun 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicolo-ribaudo Jun 5, 2022

Choose a reason for hiding this comment

Uh oh!

liuxingbaoyu left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JLHwung commented Jun 4, 2022 •

edited by gitpod-io bot

Loading

babel-bot commented Jun 4, 2022 •

edited

Loading

nicolo-ribaudo Jun 5, 2022 •

edited

Loading