Make decoratorsBeforeExport optional for 2021-12 decorators#14217
Merged
nicolo-ribaudo merged 2 commits intobabel:feat-7.16.0/decoratorsfrom Feb 1, 2022
Merged
Conversation
nicolo-ribaudo
commented
Jan 31, 2022
| name: "proposal-decorators", | ||
| inherits: syntaxDecorators, | ||
| manipulateOptions({ generatorOpts }) { | ||
| generatorOpts.decoratorsBeforeExport = decoratorsBeforeExport; |
Member
Author
There was a problem hiding this comment.
I moved this to the syntax plugin, so that syntax options validation/handling is centralized.
4 tasks
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50994/ |
JLHwung
approved these changes
Jan 31, 2022
Member
Author
|
I'm really confused - #8113 |
Member
Author
|
Oh ok it was reverted by #8465. |
sosukesuzuki
approved these changes
Feb 1, 2022
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 1, 2022
* Make `decoratorsBeforeExport` optional for 2021-12 decorators * Update fixture options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After chatting with @pzuraq, we concluded that it's likely that the proposal will continue having decorators after
export(even if it's not set in stone). We can thus make thedecoratorsBeforeExportoption optional, and if we'll ever need to change it we can just bump theversionoption.