Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c422321:
|
4cd9599 to
4753d2c
Compare
2e8225b to
8e2fdde
Compare
nicolo-ribaudo
approved these changes
Oct 10, 2021
js-choi
added a commit
to tc39/proposal-pipeline-operator
that referenced
this pull request
Oct 16, 2021
As per #91 (comment), I think my [change of the spec from `%` to `^`](#91 (comment)) was premature, partially because I now mildly prefer `%` again, but mostly because it’s what we presented to plenary on August and because it’s what Babel currently supports (see babel/babel#13749). This is a tentative change and has no bearing on what the actual final topic token will be. It’s just a swap to the explainer and spec back to what we presented to the Committee plenary on August. This will be almost certainly be the last time I switch the topic token until we hold our TC39 incubator sessions for bikeshedding the token in early November.
existentialism
approved these changes
Oct 19, 2021
374b063 to
c422321
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds option for
"topicToken": "^"to the Hack pipe operator to match the current proposal. See tc39/proposal-pipeline-operator#91 (comment).(This also fixes babel-generator only supporting
"topicToken": "#"and not"topicToken": "%".)CC @nicolo-ribaudo, @JLHwung, @tabatkins, @mAAdhaTTah, @jamiebuilds.