Use @types/node for vm module#13738
Merged
nicolo-ribaudo merged 4 commits intobabel:mainfrom Sep 8, 2021
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 946c0fa:
|
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48587/ |
Comment on lines
+85
to
+86
| let cached: { code?: string; cachedData?: Buffer } = | ||
| cachedScripts.get(filename); |
Member
There was a problem hiding this comment.
Instead of here, can you move the type annotation to the cachedScripts definition? Something like new QuickLRU<string, { code: string; cachedData?: Buffer }>().
Member
|
Can you run |
JLHwung
approved these changes
Sep 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After
Fix type at DefinitelyTyped/DefinitelyTyped#55418 and install @types/node v16.7.13