[node] Update vm by wafuwafu13 · Pull Request #55418 · DefinitelyTyped/DefinitelyTyped

wafuwafu13 · 2021-08-27T00:29:22Z

Please fill in this template.

Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Follow the advice from the readme.
Avoid common mistakes.
Run npm test <package to test>.

Select one of these and delete the others:

If adding a new definition:

The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
Create it with dts-gen --dt, not by basing it on an existing project.
Represents shape of module/library correctly
tslint.json should contain { "extends": "dtslint/dt.json" }, and no additional rules.
tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

Provide a URL to documentation or source code which provides context for the suggested changes:
Doc: https://nodejs.org/api/vm.html#vm_class_vm_script

produceCachedData When true and no cachedData is present, V8 will attempt to produce code cache data for code. Upon success, a Buffer with V8's code cache data will be produced and stored in the cachedData property of the returned vm.Script instance. The cachedDataProduced value will be set to either true or false depending on whether code cache data is produced successfully.

Code: https://github.com/nodejs/node/blob/v16.7.0/lib/vm.js#L364-L370
Example: https://github.com/babel/babel/blob/b141c85b17414c864c12e8f65f2e14ee70018d38/packages/babel-helper-transform-fixture-test-runner/src/index.ts#L105-L109

If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

If removing a declaration:

If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
Delete the package's directory.
Add it to notNeededPackages.json.

typescript-bot · 2021-08-27T00:29:55Z

@wafuwafu13 Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

node — on npm, on unpkg
- 2 added owners: @KSXGitHub, ✎@wafuwafu13

@wafuwafu13: I see that you have added yourself as an owner, are you sure you want to become an owner?

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 55418,
  "author": "wafuwafu13",
  "headCommitOid": "8643b09bd4051e41a0c50f1e46cdbc1ad74cbcc7",
  "lastPushDate": "2021-08-31T12:45:49.000Z",
  "lastActivityDate": "2021-09-07T03:55:39.000Z",
  "mergeOfferDate": "2021-09-06T22:15:42.000Z",
  "mergeRequestDate": "2021-09-07T03:55:39.000Z",
  "mergeRequestUser": "wafuwafu13",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/test/vm.ts",
          "kind": "test"
        },
        {
          "path": "types/node/vm.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Microsoft",
        "DefinitelyTyped",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "n-e",
        "galkin",
        "parambirs",
        "eps1lon",
        "SimonSchick",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "nguymin4",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "Ryan-Willpower",
        "peterblazejewicz",
        "addaleax",
        "JasonHK",
        "victorperin",
        "ZYSzys",
        "NodeJS",
        "LinusU"
      ],
      "addedOwners": [
        "KSXGitHub",
        "wafuwafu13"
      ],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "orta",
      "date": "2021-09-06T22:15:07.000Z",
      "isMaintainer": true
    },
    {
      "type": "stale",
      "reviewer": "LinusU",
      "date": "2021-08-31T12:17:33.000Z",
      "abbrOid": "8dbb0db"
    },
    {
      "type": "stale",
      "reviewer": "peterblazejewicz",
      "date": "2021-08-27T09:06:39.000Z",
      "abbrOid": "050232a"
    },
    {
      "type": "stale",
      "reviewer": "SimonSchick",
      "date": "2021-08-27T02:10:21.000Z",
      "abbrOid": "050232a"
    }
  ],
  "mainBotCommentID": 906832941,
  "ciResult": "pass"
}

typescript-bot · 2021-08-27T00:29:56Z

🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @nguymin4 @yoursunny @qwelias @ExE-Boss @Ryan-Willpower @peterblazejewicz @addaleax @JasonHK @victorperin @ZYSzys @nodejs @LinusU — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

SimonSchick · 2021-08-27T02:10:14Z

types/node/vm.d.ts

         * @since v10.6.0
         */
        createCachedData(): Buffer;
+		cachedDataProduced?: boolean | undefined;


Formatting is messed up.

You can skip the 'undefined' here.

Please make these 'readonly'.

Please move them before the constructor.

Should it be marked @deprecated as well?

This option is deprecated in favor of script.createCachedData()

@SimonSchick

Formatting is messed up.

Please see at local envirionment :)

You can skip the 'undefined' here.

All Optional Property in this file has undefined so I do this.
(But I also think undefined don't need...)

Please make these 'readonly'.

What is 'these' ? cachedDataRejected is not readonly so I didn't make it readonly.

Please move them before the constructor.

Why? cachedDataRejected is not at before the constructor.

@peterblazejewicz

Done 8dbb0db

Formatting is messed up.

Please see at local envirionment :)

It seems like you have used tabs on these rows whilst the rest of the file are using spaces, could you change to spaces?

Thanks for telling me.

typescript-bot · 2021-08-27T02:10:56Z

@wafuwafu13 One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

typescript-bot · 2021-08-27T12:31:11Z

@peterblazejewicz, @SimonSchick Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

wafuwafu13 · 2021-08-30T22:54:09Z

@peterblazejewicz

Can you please approve?

SimonSchick · 2021-08-31T01:07:41Z

The formatting is still messed up.

wafuwafu13 · 2021-08-31T12:46:25Z

Fixed.

typescript-bot · 2021-08-31T13:19:20Z

@LinusU, @peterblazejewicz, @SimonSchick Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

orta

Looks good to me node source code 👍🏻

typescript-bot · 2021-09-06T22:15:42Z

@wafuwafu13: Everything looks good here. I am ready to merge this PR (at 8643b09) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@microsoft, @DefinitelyTyped, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @SimonSchick, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @nguymin4, @yoursunny, @qwelias, @ExE-Boss, @Ryan-Willpower, @peterblazejewicz, @addaleax, @JasonHK, @victorperin, @ZYSzys, @nodejs, @LinusU: you can do this too.)

wafuwafu13 · 2021-09-07T03:55:39Z

Ready to merge

typescript-bot · 2021-09-07T04:02:46Z

I just published @types/node@16.7.12 to npm.

[node] Update vm

050232a

wafuwafu13 requested a review from peterblazejewicz as a code owner August 27, 2021 00:29

typescript-bot added Edits Owners This PR adds or removes owners Critical package labels Aug 27, 2021

SimonSchick suggested changes Aug 27, 2021

View reviewed changes

typescript-bot added the Revision needed This PR needs code changes before it can be merged. label Aug 27, 2021

Add @deprecated

8dbb0db

typescript-bot removed the Revision needed This PR needs code changes before it can be merged. label Aug 27, 2021

wafuwafu13 added 2 commits August 31, 2021 21:43

Change tab to space

2b66e32

Change tab to space

8643b09

orta approved these changes Sep 6, 2021

View reviewed changes

typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Sep 6, 2021

typescript-bot merged commit ea859ab into DefinitelyTyped:master Sep 7, 2021

wafuwafu13 mentioned this pull request Sep 7, 2021

Use @types/node for vm module babel/babel#13738

Merged

Conversation

wafuwafu13 commented Aug 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

1 package in this PR

Code Reviews

Status

Uh oh!

typescript-bot commented Aug 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SimonSchick Aug 27, 2021

Choose a reason for hiding this comment

Uh oh!

peterblazejewicz Aug 27, 2021

Choose a reason for hiding this comment

Uh oh!

wafuwafu13 Aug 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wafuwafu13 Aug 27, 2021

Choose a reason for hiding this comment

Uh oh!

LinusU Aug 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wafuwafu13 Aug 31, 2021

Choose a reason for hiding this comment

Uh oh!

typescript-bot commented Aug 27, 2021

Uh oh!

typescript-bot commented Aug 27, 2021

Uh oh!

wafuwafu13 commented Aug 30, 2021

Uh oh!

SimonSchick commented Aug 31, 2021

Uh oh!

wafuwafu13 commented Aug 31, 2021

Uh oh!

typescript-bot commented Aug 31, 2021

Uh oh!

orta left a comment

Choose a reason for hiding this comment

Uh oh!

typescript-bot commented Sep 6, 2021

Uh oh!

wafuwafu13 commented Sep 7, 2021

Uh oh!

typescript-bot commented Sep 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

wafuwafu13 commented Aug 27, 2021 •

edited

Loading

typescript-bot commented Aug 27, 2021 •

edited

Loading

typescript-bot commented Aug 27, 2021 •

edited

Loading

wafuwafu13 Aug 27, 2021 •

edited

Loading

LinusU Aug 31, 2021 •

edited

Loading