I think we should apply _getCompletionRecords and check if the completion is VariableDeclaration, e.g. The completion record of this snippet

1 + 2;
{
  var a = 1;
}

is 1 + 2.

@JLHwung Sure, done, and added a test. I have to admit that I’m a bit unsure about the code here – is it valid to assume that if the list of completion records returned by _getCompletionRecords contains a VariableDeclaration, then that automatically implies that the list has length 1? It seems like something that should be true to me, and I’m not sure how to handle this if it isn’t.

is it valid to assume that if the list of completion records returned by _getCompletionRecords contains a VariableDeclaration, then that automatically implies that the list has length 1

That's a very good question! AFAIK only IfStatement, SwitchStatement and TryStatement may produce multiple completion records, and if a VariableDeclaration is directly within these statements, it should be recursively handled here and as long as we don't return VariableDeclaration as completion records in getStatementListCompletion, then the VariableDeclaration must not come from these statements and thus the list here should contain only one completion record.

Right – that’s what I’d be thinking. :) Should I add an assertion of some kind?

an assertion of some kind

I think it's fine. The _getCompletionRecords is mostly used in proposal-do-expression, and the proposal now bans variable declaration ending in do block. So I guess few people will use it in that way.