Skip to content

test: patch verifyPackageTree for test purposes#13567

Merged
nicolo-ribaudo merged 3 commits intobabel:mainfrom
JLHwung:fix-cra-e2e-error
Jul 19, 2021
Merged

test: patch verifyPackageTree for test purposes#13567
nicolo-ribaudo merged 3 commits intobabel:mainfrom
JLHwung:fix-cra-e2e-error

Conversation

@JLHwung
Copy link
Copy Markdown
Contributor

@JLHwung JLHwung commented Jul 16, 2021

Q                       A
Fixed Issues? e2e-cra-test is failing: https://github.com/babel/babel/runs/3087195169
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Will mark as ready when CI is green.

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Jul 16, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e79a57f:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Jul 16, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47395/

@JLHwung JLHwung force-pushed the fix-cra-e2e-error branch from 70a84ba to 03f0c89 Compare July 16, 2021 15:31
@JLHwung JLHwung marked this pull request as ready for review July 16, 2021 15:48
@JLHwung
Copy link
Copy Markdown
Contributor Author

JLHwung commented Jul 16, 2021

The current CI error can also be reproduced at CRA: https://github.com/facebook/create-react-app/runs/3069230016

So we have to fix their failing main, too. 🙃

@JLHwung JLHwung requested a review from nicolo-ribaudo July 19, 2021 21:23
@nicolo-ribaudo nicolo-ribaudo merged commit fa439d6 into babel:main Jul 19, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the fix-cra-e2e-error branch July 19, 2021 21:26
nicolo-ribaudo pushed a commit to nicolo-ribaudo/babel that referenced this pull request Jul 30, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 19, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: tests outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Fixes failing main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants