Skip to content

fix(class-properties): replace new.target in static properties with undefined#13560

Merged
JLHwung merged 7 commits intobabel:mainfrom
colinaaa:fix-new-target-in-static-props
Jul 16, 2021
Merged

fix(class-properties): replace new.target in static properties with undefined#13560
JLHwung merged 7 commits intobabel:mainfrom
colinaaa:fix-new-target-in-static-props

Conversation

@colinaaa
Copy link
Copy Markdown
Contributor

@colinaaa colinaaa commented Jul 15, 2021 •
edited
Loading

Q                       A
Fixed Issues? Fixes #12737
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? 👍
Documentation PR Link
Any Dependency Changes?
License MIT

When we meet a static class property, we traverse to visit all new.target with a MetaProperty visitor.

Then we find out if or not this new.target is associated with a class by:

const func = path.findParent((path) => {
  if (path.isClass()) return true;
  if (path.isFunction() && !path.isArrowFunctionExpression()) {
    return true;
  }
  return false;
});

Now, if func is a child of prop, we do nothing. If not, that means new.target now is leaked to upper new.target, we just replace it by undefined / void 0.

if (!func.findParent((path) => path === prop)) {
  // if func is not child of prop, which means
  // `new.target` is leaked to the upper `new.target` values.
  // thus we should replace it with `undefined` (`void 0` here)
  path.replaceWith(scope.buildUndefinedNode());
}

@colinaaa
fix(class-properties): replace new.target in static properties with…
30e10b8 
… `undefined`

non-static prop is not affected

fix #12737
@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Jul 15, 2021 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47387/

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Jul 15, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f5cbf58:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JLHwung
Copy link
Copy Markdown
Contributor

JLHwung commented Jul 15, 2021

We can now enable tests packages/babel-plugin-proposal-class-static-block/test/fixtures/integration/.new-target/exec.js , once disabled in #12738. You can rename .new-target to new-target.

@colinaaa
feat: simplify thisContextVisitor
8210c00 
remove function visitor since environmentVisitor is skipping arrow function
@nicolo-ribaudo nicolo-ribaudo added PR: Spec Compliance 👓 A type of pull request used for our changelog categories Spec: Class Fields labels Jul 16, 2021
nicolo-ribaudo
nicolo-ribaudo approved these changes Jul 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

...ages/babel-plugin-proposal-class-static-block/test/fixtures/integration/new-target/output.js Outdated
var _class, _temp;

this.Foo = (_temp = _class = class {}, (() => {
// fixme: new.target should be undefined after transformed
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo Jul 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: you can delete this comment from input.js

JLHwung
JLHwung approved these changes Jul 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JLHwung JLHwung merged commit aa18da0 into babel:main Jul 16, 2021
@sync-by-unito sync-by-unito bot mentioned this pull request Jul 21, 2021
Closed
nicolo-ribaudo pushed a commit to nicolo-ribaudo/babel that referenced this pull request Jul 30, 2021
@colinaaa @existentialism @nicolo-ribaudo
fix(class-properties): replace new.target in static properties with…
0910a28 
… `undefined` (babel#13560)

* fix(class-properties): replace `new.target` in static properties with `undefined`

non-static prop is not affected

fix babel#12737

* Update packages/babel-helper-create-class-features-plugin/src/fields.ts

fix typo

Co-authored-by: Brian Ng <bng412@gmail.com>

* fix: add loose test case and fix replace condition

* test: add new.target tests for static block

* feat: move new-target replace into thisContextVisitor

defaults to replace new.target, do not replace within function

* feat: simplify thisContextVisitor

remove function visitor since environmentVisitor is skipping arrow function

* test: remove unused fixme comments

Co-authored-by: Brian Ng <bng412@gmail.com>
@sync-by-unito sync-by-unito bot mentioned this pull request Aug 2, 2021
Closed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@existentialism existentialism existentialism approved these changes

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Spec Compliance 👓 A type of pull request used for our changelog categories Spec: Class Fields

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

class-property transform leaks new.target in initializer to upper level

5 participants

@colinaaa @babel-bot @JLHwung @existentialism @nicolo-ribaudo