Skip to content

breaking(babel-8): align options naming#13518

Open
fedeci wants to merge 4 commits intobabel:mainfrom
fedeci:align-options-naming
Open

breaking(babel-8): align options naming#13518
fedeci wants to merge 4 commits intobabel:mainfrom
fedeci:align-options-naming

Conversation

@fedeci
Copy link
Copy Markdown
Member

@fedeci fedeci commented Jun 28, 2021 •
edited
Loading

Q                       A
Fixed Issues? Part of #13170
Patch: Bug Fix?
Major: Breaking Change? Yes
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Since Babel 8 should be released relatively soon, I am not sure we should already add support for this breaking change in v7.15.

edit: rebased on top of #13532

fedeci
fedeci commented Jun 28, 2021
View reviewed changes
@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Jun 28, 2021 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47768/

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Jun 28, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5e1649b:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

JLHwung
JLHwung reviewed Jun 28, 2021
View reviewed changes
JLHwung
JLHwung reviewed Jun 28, 2021
View reviewed changes
@hzoo
Copy link
Copy Markdown
Member

hzoo commented Jun 28, 2021

Should we continue these changes under the BABEL_8_BREAKING flag like the those?

@fedeci
Copy link
Copy Markdown
Member Author

fedeci commented Jun 28, 2021

Maybe yes, but what benefits would that bring? We only put more effort in handling a double source of truth for probably a couple of months(?)

@nicolo-ribaudo
Copy link
Copy Markdown
Member

nicolo-ribaudo commented Jun 28, 2021

If you prefer we can keep this as-is, and wait merging it until Babel 8.

@fedeci
Copy link
Copy Markdown
Member Author

fedeci commented Jun 29, 2021

Yes, I think it would be more sustainable.
Instead, this is a bug that should be addressed in v7.15, even if it may be a breaking change for someone.

@hzoo
Copy link
Copy Markdown
Member

hzoo commented Jun 29, 2021

Ok I just wanted too to check we were ok with it, it's a pretty small scope change otherwise? It wouldn't be great if it broke in a dep that caused issues for people but that seems unlikely?

@fedeci
Copy link
Copy Markdown
Member Author

fedeci commented Jun 29, 2021

I'm not sure if that small change broke the entire CRA e2e. I'll investigate tomorrow.

fedeci added a commit to fedeci/babel that referenced this pull request Jul 6, 2021
@fedeci
Partial babel#13518
eb9729f
@fedeci fedeci force-pushed the align-options-naming branch from 0003821 to 3b3dacb Compare July 6, 2021 16:01
@fedeci fedeci added the PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release label Jul 6, 2021
@fedeci fedeci added this to the Babel 8.0 milestone Jul 6, 2021
fedeci added a commit to fedeci/babel that referenced this pull request Jul 19, 2021
@fedeci
Partial babel#13518
d1774ca
@fedeci fedeci force-pushed the align-options-naming branch from 3b3dacb to 5e1649b Compare August 1, 2021 10:30
JLHwung pushed a commit that referenced this pull request Aug 19, 2021
@fedeci
fix: set parserOpts.sourceFilename from root sourceFileName (#13532)
51a0caa 
* Partial #13518

* Update tests
@JLHwung JLHwung removed the babel 8 label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JLHwung JLHwung JLHwung left review comments

Assignees

No one assigned

Labels

PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release

Projects

None yet

Milestone

v8.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@fedeci @babel-bot @hzoo @nicolo-ribaudo @JLHwung @liuxingbaoyu