babel-parser: Add new internal ESLint rule to consistent error messages#13130
Merged
nicolo-ribaudo merged 7 commits intobabel:feat-7.14.0/parser-updatesfrom Apr 11, 2021
Conversation
Contributor
Author
|
Oh, this PR includes huge diffs.. But almost diff are updating snapshots. |
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45136/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 207f2fb:
|
JLHwung
approved these changes
Apr 9, 2021
Contributor
JLHwung
left a comment
There was a problem hiding this comment.
LGTM.
Note for reviewers: I suggest reviewing the first 3 commits, the others are snapshot changes.
js-choi
added a commit
to js-choi/babel
that referenced
this pull request
Apr 9, 2021
js-choi
added a commit
to js-choi/babel
that referenced
this pull request
Apr 9, 2021
js-choi
added a commit
to js-choi/babel
that referenced
this pull request
Apr 9, 2021
js-choi
added a commit
to js-choi/babel
that referenced
this pull request
Apr 9, 2021
Member
|
I rebased |
9571427 to
13d1014
Compare
e847f90 to
e9aed2c
Compare
Member
|
Thanks! I had to reword the commit message a bit so that it doesn't get cropped by GH's ui. |
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Apr 13, 2021
js-choi
added a commit
to js-choi/babel
that referenced
this pull request
Apr 14, 2021
js-choi
added a commit
to js-choi/babel
that referenced
this pull request
Apr 14, 2021
JLHwung
pushed a commit
that referenced
this pull request
Apr 16, 2021
JLHwung
pushed a commit
that referenced
this pull request
Apr 17, 2021
JLHwung
pushed a commit
that referenced
this pull request
Apr 19, 2021
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Apr 20, 2021
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Apr 22, 2021
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Apr 23, 2021
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Apr 26, 2021
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Apr 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been concerned about the inconsistent in the format of error messages. However, tools such as Prettier use error messages as their interface, and It wasn't able to fixed.
With the introduction of error codes in 7.14, it is now easier to fix error messages.
So I created an Internal ESLint rule to enforce the format of error messages.
What do you think about this?