Skip to content

[babel 8] Don't create TSParenthesizedType nodes by default#12608

Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom
JLHwung:backport-11200
Jan 13, 2021
Merged

[babel 8] Don't create TSParenthesizedType nodes by default#12608
nicolo-ribaudo merged 1 commit intobabel:mainfrom
JLHwung:backport-11200

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jan 11, 2021

Q                       A
Fixed Issues? Closes #11200, fixes #9546
Patch: Bug Fix?
Major: Breaking Change? Y, but behind BABEL_8_BREAKING flag
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link babel/website#2765
Any Dependency Changes?
License MIT

This PR backports #11200 so we can merge to the main branch.

@babel-bot
Copy link
Collaborator

babel-bot commented Jan 11, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/37285/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 11, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit afdf94e:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo changed the title Backport #11200 [babel 8] Don't create TSParenthesizedType nodes by default Jan 12, 2021
Only create them when the `createParenthesizedExpressions` parser option
is enabled.

Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
@nicolo-ribaudo nicolo-ribaudo merged commit 62290aa into babel:main Jan 13, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the backport-11200 branch January 13, 2021 00:13
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2021
@nicolo-ribaudo nicolo-ribaudo added babel 8 PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release and removed babel-8-dev → main babel 8 labels Aug 8, 2023
@JLHwung JLHwung added this to the v8.0.0 milestone Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[breaking] Remove TSParenthesizedType unless createParenthesizedExpressions is enabled

5 participants