Disallow setting assumptions to false in presets#12498
Merged
nicolo-ribaudo merged 3 commits intoDec 14, 2020
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/35177/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8435f26:
|
JLHwung
reviewed
Dec 12, 2020
| loadOptions({ | ||
| presets: [() => ({ assumptions: { mutableTemplateObject: false } })], | ||
| }), | ||
| ).toThrow(); |
Contributor
There was a problem hiding this comment.
Nit: add error message assertion here so it doesn't pass on incorrect error messages.
JLHwung
approved these changes
Dec 12, 2020
hzoo
approved these changes
Dec 14, 2020
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Jan 12, 2021
* Disallow setting assumptions to `false` in presets * Error message * Fix
nicolo-ribaudo
added a commit
that referenced
this pull request
Jan 24, 2021
* Disallow setting assumptions to `false` in presets * Error message * Fix
nicolo-ribaudo
added a commit
that referenced
this pull request
Jan 24, 2021
* Disallow setting assumptions to `false` in presets * Error message * Fix
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Feb 4, 2021
* Disallow setting assumptions to `false` in presets * Error message * Fix
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Feb 10, 2021
* Disallow setting assumptions to `false` in presets * Error message * Fix
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Feb 11, 2021
* Disallow setting assumptions to `false` in presets * Error message * Fix
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 16, 2021
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 16, 2021
- Disallow setting assumptions to `false` in presets (#12498)
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 21, 2021
- Disallow setting assumptions to `false` in presets (#12498)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reading the RFC again, I noticed that my previous implementation didn't exactly reflect it.
(discussion - Sorry I minimized it because I coudn't find the "Mark as resolved" button and now I can't un-minimize them)
This PR needs to be merged before 7.13, otherwise it would be a breaking change.