Parse class static block#12079
Merged
nicolo-ribaudo merged 9 commits intobabel:feat-7.12.0/class-static-blockfrom Oct 6, 2020
Merged
Parse class static block#12079nicolo-ribaudo merged 9 commits intobabel:feat-7.12.0/class-static-blockfrom
nicolo-ribaudo merged 9 commits intobabel:feat-7.12.0/class-static-blockfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/29367/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e53fdfd:
|
ffd03b5 to
7ae65f3
Compare
nicolo-ribaudo
approved these changes
Sep 28, 2020
existentialism
approved these changes
Sep 30, 2020
Member
existentialism
left a comment
There was a problem hiding this comment.
👍 outside of a minor question around the error message
kaicataldo
approved these changes
Oct 1, 2020
| stop: boolean, | ||
| }; | ||
|
|
||
| export type ParseClassMemberState = {| |
Member
There was a problem hiding this comment.
TIL I learned about Flow's exact object types 👍🏼
Co-authored-by: Brian Ng <bng412@gmail.com>
c40f8e1 to
9e8864d
Compare
Member
|
@JLHwung I'm merging this into the |
2 tasks
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Oct 14, 2020
Co-authored-by: Brian Ng <bng412@gmail.com>
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Oct 14, 2020
Co-authored-by: Brian Ng <bng412@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements parsing/generating support for the Stage 2 Class Static Block Proposal.
Note that current implementation is aligned to tc39/proposal-class-static-block#15.
/cc @ljharb @rbuckton