Throw a syntax error for a constructor with type parameters#12065
Merged
JLHwung merged 3 commits intobabel:mainfrom Sep 17, 2020
Merged
Throw a syntax error for a constructor with type parameters#12065JLHwung merged 3 commits intobabel:mainfrom
JLHwung merged 3 commits intobabel:mainfrom
Conversation
sosukesuzuki
commented
Sep 16, 2020
| withStatementErrors.ts | ||
| withStatementInternalComments.ts | ||
| withStatementNestedScope.ts | ||
| parserConstructorDeclaration12.ts |
Contributor
Author
There was a problem hiding this comment.
class C {
constructor<>() { }
constructor<> () { }
constructor <>() { }
constructor <> () { }
constructor< >() { }
constructor< > () { }
constructor < >() { }
constructor < > () { }
}
Member
There was a problem hiding this comment.
Can you update this line:
Line 3 in bbe0cf0
to update the TS tests?
And then run
make test-typescript-update-allowlist
Contributor
Author
There was a problem hiding this comment.
I've fixed at 7a02112! But I'm not familiar with how babel-parser tests work, so I'm not sure if it's correct.
Member
There was a problem hiding this comment.
It's correct! Btw, allowlist contain tests that we don't pass and not tests that we are correctly handling.
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/28463/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7a02112:
|
kaicataldo
reviewed
Sep 16, 2020
Update allowlist.txt
c7fa9bd to
7a02112
Compare
existentialism
approved these changes
Sep 17, 2020
Contributor
|
The CI error is not related. I will address it in a separate PR. |
3 tasks
sosukesuzuki
added a commit
to sosukesuzuki/prettier
that referenced
this pull request
Oct 15, 2020
sosukesuzuki
added a commit
to prettier/prettier
that referenced
this pull request
Oct 20, 2020
* Install babel/parser 7.12 * Add tests for babel/babel#12161 * Add test for babel/babel#12076 * Add test for babel/babel#12085 * Add test for babel/babel#12108 * Add test for babel/babel#12120 * Add test for babel/babel#12054 * Add test for babel/babel#12061 * Add test babel/babel#12093 * Add test for babel/babel#12065 * Add test for babel/babel#12111 * Add test for babel/babel#12072 * Switch syntax-module-attributes to syntax-import-assertion * Support "String import/export specifier" * Remove tests for module-attributes * Add changelog * Update to 7.12.3 * Fix by linter * Fix by spellchecker * Add tests for module attributes to errors * Add error test for module string name with import * Remove TSTypeCastExpression * Add tests for funny import-assertions * Update snapshots| * Add more tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.