fix: ensure explicit file extensions in "exports" #11283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
existentialism
approved these changes
Mar 18, 2020
Member
|
@guybedford thanks! |
Member
|
Oh, thanks! |
4 tasks
6 tasks
michaelsbradleyjr
added a commit
to embarklabs/embark
that referenced
this pull request
Apr 24, 2020
Node v13.13.0 introduced a change that is incompatible with `@babel/preset-env` versions `< 7.9.0`. See: nodejs/node#32351 nodejs/node#32852 babel/babel#11283 Bump our direct dependencies to `7.9.5` and manually cause additional bumps in `yarn.lock` that result in all versions of `@babel/preset-env` installed in the monorepo's `node_modules` trees being `>= 7.9.0`.
michaelsbradleyjr
added a commit
to embarklabs/embark
that referenced
this pull request
Apr 24, 2020
Node v13.13.0 introduced a change that is incompatible with `@babel/preset-env` versions `< 7.9.0`. See: * nodejs/node#32351 * nodejs/node#32852 * babel/babel#11283 Bump our direct dependencies to `7.9.5` and manually cause additional bumps in `yarn.lock` that result in all versions of `@babel/preset-env` installed in the monorepo's `node_modules` trees being `>= 7.9.0`.
michaelsbradleyjr
added a commit
to embarklabs/embark
that referenced
this pull request
Apr 24, 2020
Node v13.13.0 introduced a change that is incompatible with `@babel/preset-env` versions `< 7.9.0`. See: * nodejs/node#32351 * nodejs/node#32852 * babel/babel#11283 Bump our direct dependencies to `7.9.5` and manually cause additional bumps in `yarn.lock` that result in all versions of `@babel/preset-env` installed in the monorepo's `node_modules` trees being `>= 7.9.0`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js requires "exports" to use explicit file extensions.
That this was working was actually a bug in the modules implementation that will be patched soon, and I'm working on the PR for this.
Posting this PR first thing so that hopefully Babel can avoid any compat issues here when that fix finds its way downstream to a future Node.js release.
Happy to answer any questions further on this too.