Handle private access chained on an optional chain by jridgewell · Pull Request #11248 · babel/babel

jridgewell · 2020-03-12T05:39:56Z

Q	A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?	Yes
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

See the resolution from tc39/proposal-class-fields#301.

We intend to allow devs to access private properties in the optional chains, eg foo?.bar.#baz. We're still debating whether to allow the private property to start the optional chain, eg foo?.#baz.

--- Edits By @JLHwung ---

Todo list tracking ?. PrivateIdentifier support

nicolo-ribaudo

This is the most important comment: #11248 (comment)

This is a mix of changes, most importantly: - Always print parens when mixing nullish coalescing and another logical - Fixes assignment in the callee of an optional chain, which now blocks babel#11248 Also, cleans up a bit of code, and removes an unnecessary parens around `class A extends new B {}`

This is a mix of changes, most importantly: - Always print parens when mixing nullish coalescing and another logical - Fixes assignment in the callee of an optional chain, which now blocks #11248 Also, cleans up a bit of code, and removes an unnecessary parens around `class A extends new B {}`

nicolo-ribaudo

Thanks!

babel-bot · 2020-05-20T18:43:23Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/22849/

codesandbox-ci · 2020-05-20T18:45:56Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6c4486f:

Sandbox	Source
compassionate-leftpad-exj48	Configuration
distracted-knuth-q0ol1	Configuration

JLHwung · 2020-05-21T15:53:06Z

I am converting this PR to draft as transforming ?. PrivateIdentifier is still WIP.

nicolo-ribaudo · 2020-05-21T16:12:12Z

Whops I clicked "Approve" on the wrong PR

See the resolution from tc39/proposal-class-fields#301.

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

JLHwung · 2020-05-25T17:18:23Z

✅On changes by @jridgewell . But this PR needs approval other than myself on my changes.

Thanks for @nicolo-ribaudo who inspires me on the #m?.() support!

nicolo-ribaudo

Thanks for figuring out the #m?.() after I offered my help and then failed 😂

nicolo-ribaudo · 2020-05-25T19:40:51Z

-    (_getSelf6 = (_ref22 = fn === null || fn === void 0 ? void 0 : _classPrivateFieldLooseBase(fn().Foo, _self)[_self]) === null || _ref22 === void 0 ? void 0 : (_ref22$getSelf = _ref22.getSelf) === null || _ref22$getSelf === void 0 ? void 0 : _ref22$getSelf.call(_ref22)) === null || _getSelf6 === void 0 ? void 0 : _classPrivateFieldLooseBase(_getSelf6.self, _m)[_m]();
+    (_call2 = (_ref20 = fn === null || fn === void 0 ? void 0 : (_classPrivateFieldLoo4 = _classPrivateFieldLooseBase(fn().Foo, _self)[_self]).getSelf) == null ? void 0 : _ref20.call(_classPrivateFieldLoo4)) === null || _call2 === void 0 ? void 0 : _classPrivateFieldLooseBase(_call2.self, _m)[_m]();
+    (_getSelf5 = (_ref21 = fn === null || fn === void 0 ? void 0 : _classPrivateFieldLooseBase(fn().Foo, _self)[_self]) == null ? void 0 : _ref21.getSelf()) === null || _getSelf5 === void 0 ? void 0 : _classPrivateFieldLooseBase(_getSelf5.self, _m)[_m]();
+    (_getSelf6 = (_ref22 = fn === null || fn === void 0 ? void 0 : _classPrivateFieldLooseBase(fn().Foo, _self)[_self]) == null ? void 0 : _ref22.getSelf == null ? void 0 : _ref22.getSelf()) === null || _getSelf6 === void 0 ? void 0 : _classPrivateFieldLooseBase(_getSelf6.self, _m)[_m]();


In the future we'll figure out how to use == null here.

We could add loose support to

babel/packages/babel-helper-member-expression-to-functions/src/index.js

Line 143 in b457f52

export default function memberExpressionToFunctions(path, visitor, state) {

existentialism

@jridgewell some fantastic code comments in this PR!

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>

jridgewell added PR: New Feature 🚀 A type of pull request used for our changelog categories Spec: Class Fields Spec: Optional Chaining Spec: Private Methods labels Mar 12, 2020

nicolo-ribaudo added the pkg: parser label Mar 12, 2020

nicolo-ribaudo reviewed Mar 12, 2020

View reviewed changes

jridgewell mentioned this pull request Mar 13, 2020

Is there also a nullish AND? tc39/proposal-nullish-coalescing#61

Closed

jridgewell mentioned this pull request Mar 13, 2020

Fix printing edge cases in Nullish Coalescing and Optional Chaining #11255

Merged

jridgewell force-pushed the optional-private branch 2 times, most recently from fa21565 to 54b2109 Compare March 15, 2020 08:48

nicolo-ribaudo approved these changes Mar 15, 2020

View reviewed changes

nicolo-ribaudo added this to the v7.10.0 milestone Mar 22, 2020

JLHwung reviewed Apr 27, 2020

View reviewed changes

Comment thread packages/babel-parser/src/parser/expression.js Outdated

JLHwung mentioned this pull request Apr 28, 2020

add ?. PrivateIdentifier test compat-table/compat-table#1612

Merged

nicolo-ribaudo mentioned this pull request May 18, 2020

private-in-obj and integration between private and ?. #11586

Merged

3 tasks

nicolo-ribaudo changed the base branch from master to feat-7.10.0/private-stuff May 18, 2020 19:16

JLHwung force-pushed the optional-private branch from 54b2109 to e7534b9 Compare May 20, 2020 18:37

babel deleted a comment from codesandbox-ci Bot May 20, 2020

JLHwung mentioned this pull request May 21, 2020

chore: update test262 #11590

Merged

nicolo-ribaudo reviewed May 21, 2020

View reviewed changes

Comment thread packages/babel-helper-member-expression-to-functions/src/index.js

JLHwung marked this pull request as draft May 21, 2020 15:51

nicolo-ribaudo approved these changes May 21, 2020

View reviewed changes

nicolo-ribaudo force-pushed the feat-7.10.0/private-stuff branch from 4379f5c to b1b28b7 Compare May 21, 2020 17:11

Handle private access chained on an optional chain

d8a38b8

See the resolution from tc39/proposal-class-fields#301.

JLHwung force-pushed the optional-private branch 3 times, most recently from 397d516 to 9635a42 Compare May 22, 2020 15:34

feat: support ?.#x and ?.#m()

785b6e8

JLHwung force-pushed the optional-private branch from 9635a42 to 785b6e8 Compare May 22, 2020 20:44

JLHwung added 3 commits May 22, 2020 20:50

chore: run test on node 14

1788e52

fix: don’t memoise static base ref

f08975b

test: add test cases for #m?.()

55bdc00

JLHwung force-pushed the optional-private branch from adf0cc8 to 55bdc00 Compare May 24, 2020 22:12

JLHwung reviewed May 25, 2020

View reviewed changes

Comment thread packages/babel-helper-member-expression-to-functions/src/index.js Outdated

add #m?.() support

12eb77b

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

JLHwung force-pushed the optional-private branch from 47606f5 to bef24ba Compare May 25, 2020 17:10

JLHwung marked this pull request as ready for review May 25, 2020 17:15

JLHwung requested a review from nicolo-ribaudo May 25, 2020 17:19

add loose test cases

aee43de

JLHwung force-pushed the optional-private branch from 9d9ec1a to aee43de Compare May 25, 2020 18:02

nit: .call is always computed: false

970a5a1

nicolo-ribaudo approved these changes May 25, 2020

View reviewed changes

existentialism approved these changes May 26, 2020

View reviewed changes

JLHwung added 2 commits May 26, 2020 11:58

fix: avoid reuse ast node

08160d8

fix: throw early error for delete this?.#x

6c4486f

nicolo-ribaudo approved these changes May 26, 2020

View reviewed changes

nicolo-ribaudo merged commit a0747ae into babel:feat-7.10.0/private-stuff May 26, 2020

jridgewell deleted the optional-private branch May 26, 2020 20:18

nicolo-ribaudo added a commit that referenced this pull request May 26, 2020

Handle private access chained on an optional chain (#11248)

bda759a

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>

JLHwung mentioned this pull request Jun 3, 2020

Add delete obj?.#x.a support #11669

Merged

nicolo-ribaudo mentioned this pull request Jun 7, 2020

Replace "loose" options with a top-level "assumptions" object babel/rfcs#5

Merged

github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 26, 2020

github-actions Bot locked as resolved and limited conversation to collaborators Aug 26, 2020

Uh oh!

Conversation

jridgewell commented Mar 12, 2020 • edited by JLHwung Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolo-ribaudo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

babel-bot commented May 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codesandbox-ci Bot commented May 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

JLHwung commented May 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolo-ribaudo commented May 21, 2020

Uh oh!

Uh oh!

JLHwung commented May 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

Uh oh!

nicolo-ribaudo May 25, 2020

Choose a reason for hiding this comment

Uh oh!

JLHwung May 25, 2020

Choose a reason for hiding this comment

Uh oh!

existentialism left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jridgewell commented Mar 12, 2020 •

edited by JLHwung

Loading

nicolo-ribaudo left a comment •

edited

Loading

babel-bot commented May 20, 2020 •

edited

Loading

codesandbox-ci Bot commented May 20, 2020 •

edited

Loading

JLHwung commented May 21, 2020 •

edited

Loading

JLHwung commented May 25, 2020 •

edited

Loading