fix(parser): add missing @babel/types dependency#11118
fix(parser): add missing @babel/types dependency#11118merceyz wants to merge 1 commit intobabel:masterfrom
Conversation
|
I'm wondering how it's possible that I didn't notice it while testing yarn 2 on this repository 🤔 |
|
It's only required in the typescript types. babel/packages/babel-parser/typings/babel-parser.d.ts Lines 8 to 16 in 143d159 |
|
Oh right, I forgot about it. Related: #10315, #9924. I don't think that we should add a whole dependency only used for TS types. I think that we have 3 options:
cc @babel/babel |
|
Is there an |
It was in my search history and I assumed that it existed 😅
We are dropping Node.js <10.13 in Babel 8, and v10.13.0 has npm v6.12.0 which supports peerDepsMeta. However, I think that this is sub-optimal and I would prefer my third suggestion. |
Jest (@SimenB) is testing Yarn 2 (jestjs/jest#9476) and their TypeScript build failed because
@babel/parseris missing a dependency on@babel/types.