--copy-ignored flag added to CLI by rajasekarm · Pull Request #10887 · babel/babel

rajasekarm · 2019-12-18T10:24:47Z

Q	A
Fixed Issues?	Fixes #6226
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?	Yes
Tests Added + Pass?	Yes
Documentation PR Link	babel/website#2151
Any Dependency Changes?
License	MIT

nicolo-ribaudo · 2019-12-18T11:02:55Z

Reviews at #10831

JLHwung · 2019-12-18T14:32:57Z

packages/babel-cli/src/babel/dir.js

+    if (
+      !written &&
+      ((!isCompilableExtension && cliOptions.copyFiles) ||
+        cliOptions.includeIgnored)


I think we should throw in parseArgv when copyFiles: false, includeIgnored: true, otherwise we will have another flag that could copy non compilable files.

🚲🏠 warning:

Should we call it --copy-ignored? 😝

Changed to --copy-ignored

JLHwung · 2019-12-18T14:35:35Z

...ages/babel-cli/test/fixtures/babel/--copy-files with ignore with includeIgnored/options.json

@@ -0,0 +1,12 @@
+{
+  "args": [


Can you add a test for --only?

babel src --out-dir lib --copy-files --only src/main/* --include-ignored

and a test when --include-ignored is not enabled (default of v7.8), so that we can make sure the old behaviour preserves.

Is this still needed?

Good to have.😀

Added a test case for this.

https://github.com/rajasekarm/babel/tree/fix/10829/packages/babel-cli/test/fixtures/babel/error%20--copy-files%20--only%20--copy-ignored

rajasekarm · 2019-12-20T13:30:17Z

I'm throwing error if --copy-ignored is used without ignore flag. Which will solve other corner cases.

JLHwung · 2019-12-22T01:55:04Z

...li/test/fixtures/babel/--copy-files --include-dotfiles with ignore/out-files/lib/foo/.foo.js

@@ -1 +0,0 @@
-a;


🤔Why is .foo.js not copied?

we've --include-dotfile to Include dotfiles when compiling and copying non-compilable files.

https://github.com/rajasekarm/babel/blob/master/packages/babel-cli/src/babel/options.js#L148

Yeah, it was copied before this PR. But now .foo.js has been removed from the out files, which means it is not copied.

I got it, I'll check.

I've that file in my branch, https://github.com/rajasekarm/babel/blob/master/packages/babel-cli/test/fixtures/babel/--copy-files%20--include-dotfiles%20with%20ignore/out-files/lib/foo/.foo.js

I dono why github shows this as removed.

The linked one is your master branch, not the PR branch 😛

Yeah, I'm check this.

Found the root cause of this bug, I'm fixing it.

.foo.js is inside src/foo and it is in ignored list. So it is not copied.

rajasekarm · 2019-12-25T17:42:46Z

I've exposed pathToPattern function from @babel/core for the ignore file check.

nicolo-ribaudo · 2019-12-25T18:18:14Z

I've exposed pathToPattern function from @babel/core for the ignore file check.

I have bad news for you 😛
This is a breaking change because if someone used @babel/core v7.7.7 and updates @babel/cli to 7.8.0 won't work.
For now, we can duplicate the code (with comments to explain that it's duplicated and if it is updated it should be done in both places) and then revisit it for Babel 8.

rajasekarm · 2019-12-25T19:26:19Z

Sure, I'll make the change.

rajasekarm · 2019-12-25T21:01:05Z

@nicolo-ribaudo Done 👍

(I need to review this PR again)

nicolo-ribaudo · 2019-12-25T23:40:05Z

I was looking at the write function in packages/babel-cli/src/babel/dir.js. From what I understood, it can return false in three cases:

The extension is not compatible (first return false)
The file has been ignored, and thus babel.transformSync (aka util.compile) returns null
There was an error.

If we make the write function return a string enum rather than a boolean, maybe we could avoid checking if the file has been ignored? Also, I think that the current approach doesn't work well if a file has been ignored not using a cli option, but using a config file.

rajasekarm · 2019-12-27T13:10:57Z

@nicolo-ribaudo I made the requested change. Can you please check?

nicolo-ribaudo

The code now looks way cleaner!

rajasekarm added this to the v7.8.0 milestone Dec 18, 2019

rajasekarm added pkg: cli PR: New Feature 🚀 A type of pull request used for our changelog categories labels Dec 18, 2019

rajasekarm changed the title ~~Reopen - Prevent ignored files in out dir~~ Reopen - includeIgnored flag added to CLI Dec 18, 2019

nicolo-ribaudo added the PR: Ready For Review label Dec 18, 2019

JLHwung reviewed Dec 18, 2019

View reviewed changes

rajasekarm requested review from JLHwung and existentialism December 20, 2019 13:30

rajasekarm changed the title ~~Reopen - includeIgnored flag added to CLI~~ Reopen - --include-ignored flag added to CLI Dec 20, 2019

nicolo-ribaudo previously approved these changes Dec 20, 2019

View reviewed changes

existentialism approved these changes Dec 20, 2019

View reviewed changes

nicolo-ribaudo added PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release and removed PR: Ready For Review labels Dec 20, 2019

nicolo-ribaudo removed the request for review from JLHwung December 20, 2019 23:38

JLHwung reviewed Dec 22, 2019

View reviewed changes

nicolo-ribaudo changed the title ~~Reopen - --include-ignored flag added to CLI~~ Reopen - --copy-ignored flag added to CLI Dec 25, 2019

rajasekarm changed the title ~~Reopen - --copy-ignored flag added to CLI~~ copy-ignored flag added to CLI Dec 27, 2019

rajasekarm changed the title ~~copy-ignored flag added to CLI~~ --copy-ignored flag added to CLI Dec 27, 2019

nicolo-ribaudo approved these changes Dec 27, 2019

View reviewed changes

nicolo-ribaudo requested a review from JLHwung December 27, 2019 18:18

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 24, 2020

github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2020

JLHwung removed the PR: Needs Docs label Feb 23, 2026

Uh oh!

Conversation

rajasekarm commented Dec 18, 2019 • edited by JLHwung Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolo-ribaudo commented Dec 18, 2019

Uh oh!

JLHwung Dec 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JLHwung Dec 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rajasekarm Dec 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rajasekarm commented Dec 20, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rajasekarm commented Dec 25, 2019

Uh oh!

nicolo-ribaudo commented Dec 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rajasekarm commented Dec 25, 2019

Uh oh!

rajasekarm commented Dec 25, 2019

Uh oh!

nicolo-ribaudo commented Dec 25, 2019

Uh oh!

rajasekarm commented Dec 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rajasekarm commented Dec 18, 2019 •

edited by JLHwung

Loading

JLHwung Dec 18, 2019 •

edited

Loading

JLHwung Dec 18, 2019 •

edited

Loading

rajasekarm Dec 25, 2019 •

edited

Loading

nicolo-ribaudo commented Dec 25, 2019 •

edited

Loading

rajasekarm commented Dec 27, 2019 •

edited

Loading