Prevent ignored files in out dir#10831
Conversation
|
C.f. #10829 (comment)
I am afraid people could rely on this behaviour to copy ignored files. Since I propose to add an |
|
That can be done, But I assume it should copy only the non supported format files and not the ignored one. Example css is non supported format, can be copied and required for the app to run. Test files are ignored and not copied and not required for the app to run. |
|
@rajasekarm Given the behaviour has been existed since v7, I would prefer we add this behind a flag. And later we can change the defaults in v8, so that practically it will skip the |
|
Sure, I'll make the change. Thanks for your input @JLHwung. |
|
@JLHwung Added the flag, I named it as includeIgnore. |
|
|
||
| commander.option( | ||
| "--include-ignore", | ||
| "Include ignored files when compiling and copy to destination", |
There was a problem hiding this comment.
Do we need to rephrase this help text?
Copy review. Co-Authored-By: Brian Ng <bng412@gmail.com>
|
|
||
| commander.option( | ||
| "--include-ignore", | ||
| "Include ignored files when compiling and copying non-compilable files.", |
There was a problem hiding this comment.
🤔I don't think ignored file will be compiled when --include-ignore is true, it is different than --include-dotfiles.
Personally I prefer --include-ignored than --include-ignore because ignore is a verb.
There was a problem hiding this comment.
Yeah, we can drop the compiling bit.
There was a problem hiding this comment.
@JLHwung , I'll make the the change for the flag. Is the below text ok for you? Just want to confirm before pushing the change.
Include ignored files and copying non-compilable files.
There was a problem hiding this comment.
I feel like it is
Include ignored files when copying non-compilable files.
This reverts commit 2b35909.
--ignore folder should not be present in out dir.