Fix: inputSourceMap should work when it is an external file#10623
Merged
JLHwung merged 3 commits intobabel:masterfrom Oct 31, 2019
Merged
Fix: inputSourceMap should work when it is an external file#10623JLHwung merged 3 commits intobabel:masterfrom
JLHwung merged 3 commits intobabel:masterfrom
Conversation
JLHwung
commented
Oct 31, 2019
| return 4; | ||
| }; | ||
|
|
||
| //# sourceMappingURL=input.js.map |
Contributor
Author
There was a problem hiding this comment.
The test case is copied and later transformed from packages/babel-core/test/fixtures/transformation/source-maps/input-source-map.
jridgewell
approved these changes
Oct 31, 2019
nicolo-ribaudo
approved these changes
Oct 31, 2019
This was referenced Nov 28, 2019
This was referenced Dec 5, 2019
This was referenced Dec 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes invalid
fromMapFileCommentcall signature via prepending parsed comment text by//, which is required inconvert-source-map.This PR is a follow up to #9960.