Do not delete "fake" source map comments from strings#9960
Merged
nicolo-ribaudo merged 1 commit intobabel:masterfrom Aug 14, 2019
Merged
Do not delete "fake" source map comments from strings#9960nicolo-ribaudo merged 1 commit intobabel:masterfrom
nicolo-ribaudo merged 1 commit intobabel:masterfrom
Conversation
Instead of using `convert-source-map`'s `removeComments` method before parsing the file, we can first parse the file with `@babel/parser` and then analyze the comments. This is needed because it is not possible to reliabily detect comments in JavaScript without fully parsing the file: thlorenz/convert-source-map#63
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10774/ |
1 similar comment
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10774/ |
danez
approved these changes
May 8, 2019
Member
Author
|
@tanhauhau @JLHwung I noticed your 👍s on this PR. Does it mean that you have reviewed it? I'm asking because you are both more involved than the "casual 👍ers" 😅 |
Contributor
|
@nicolo-ribaudo 🤦♂️ Sometimes I thumb up for epic PRs (especially merged). But this one looks good to me. |
This was referenced Sep 17, 2019
This was referenced Oct 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit message: