throw a TypeError if identifier validation fails#10621
Merged
nicolo-ribaudo merged 2 commits intobabel:masterfrom Nov 2, 2019
Merged
throw a TypeError if identifier validation fails#10621nicolo-ribaudo merged 2 commits intobabel:masterfrom
nicolo-ribaudo merged 2 commits intobabel:masterfrom
Conversation
1 similar comment
JLHwung
approved these changes
Nov 1, 2019
jridgewell
approved these changes
Nov 1, 2019
Member
jridgewell
left a comment
There was a problem hiding this comment.
🙌
I've had to depend on and import esutils in a few projects because this was never exposed. Yay!
Contributor
|
@jridgewell We do have plan to refactor it. In the near future babel-types will not depend on |
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Nov 5, 2019
This reverts commit c7d8b8a.
This was referenced Nov 14, 2019
This was referenced Nov 28, 2019
This was referenced Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that
t.identifier(name)accepts invalid identifiers, this PR fixes that bug. Thanks to @JLHwung for finding the reason so quickly!