Skip to content

Add support for TS declare types to types and generator#10544

Merged
nicolo-ribaudo merged 1 commit intofeat-7.7/ts-declare-fieldsfrom
nicolo-ribaudo/ts-declare-field-types
Nov 5, 2019
Merged

Add support for TS declare types to types and generator#10544
nicolo-ribaudo merged 1 commit intofeat-7.7/ts-declare-fieldsfrom
nicolo-ribaudo/ts-declare-field-types

Conversation

@nicolo-ribaudo
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo commented Oct 13, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: generator area: typescript pkg: types labels Oct 13, 2019
@nicolo-ribaudo nicolo-ribaudo added this to the TypeScript 3.7 milestone Oct 13, 2019
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Oct 13, 2019
Merged
3 tasks
@nicolo-ribaudo nicolo-ribaudo force-pushed the feat-7.7/ts-declare-fields branch from 9cf1244 to 6faf79a Compare October 13, 2019 23:00
@nicolo-ribaudo nicolo-ribaudo force-pushed the nicolo-ribaudo/ts-declare-field-types branch from b9d4d13 to 7aad209 Compare October 13, 2019 23:01
@nicolo-ribaudo nicolo-ribaudo added the PR: Needs Review A pull request awaiting more approvals label Oct 17, 2019
@nicolo-ribaudo nicolo-ribaudo force-pushed the feat-7.7/ts-declare-fields branch from 6faf79a to 16e5870 Compare October 22, 2019 22:26
@nicolo-ribaudo nicolo-ribaudo force-pushed the nicolo-ribaudo/ts-declare-field-types branch from 7aad209 to b9c5dcb Compare October 22, 2019 22:27
@nicolo-ribaudo nicolo-ribaudo merged commit d31cab5 into feat-7.7/ts-declare-fields Nov 5, 2019
@nicolo-ribaudo nicolo-ribaudo deleted the nicolo-ribaudo/ts-declare-field-types branch November 5, 2019 00:51
@nicolo-ribaudo
Copy link
Copy Markdown
Member Author

nicolo-ribaudo commented Nov 5, 2019

Merged to #10545 (not in master yet)

nicolo-ribaudo added a commit that referenced this pull request Nov 5, 2019
@nicolo-ribaudo
Add support for TS declare types to types and generator (#10544)
fe37a64
nicolo-ribaudo added a commit that referenced this pull request Nov 5, 2019
@nicolo-ribaudo
Add support for TS declare types to types and generator (#10544)
94b842b
nicolo-ribaudo added a commit that referenced this pull request Nov 5, 2019
@nicolo-ribaudo
Add support for TS declare modifier on fields (#10545)
e9c1bce 
* [parser] Add support for TS declare modifier on fields (#10484)

* [parser] Add support for TS declare modifier on fields

* Use Object.create(null)

* Comment

* Add support for TS declare types to types and generator (#10544)

* Transform TypeScript "declare" fields (#10546)

* Transform TypeScript "declare" fields

* Remove multiple spaces

* declareFields -> allowDeclareFields

* Update after rebase
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 4, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JLHwung JLHwung JLHwung approved these changes

Assignees

No one assigned

Labels

area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator pkg: types PR: Needs Review A pull request awaiting more approvals PR: New Feature 🚀 A type of pull request used for our changelog categories

Projects

None yet

Milestone

TypeScript 3.7

Development

Successfully merging this pull request may close these issues.

2 participants

@nicolo-ribaudo @JLHwung