Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11717/ |
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11209/ |
Member
|
Good idea. For inspiration I have a similar setup here https://github.com/xtuc/webassemblyjs/blob/master/appveyor.yml#L11, with Make, lerna, etc. |
Member
Author
|
Travis throws that Also, I'll disable tests on older node versions; I think that it is enought to test only one with windows. |
Member
|
I guess we would need #9674 first? I want to start on this soon. |
Member
Author
|
We can have a |
4157c70 to
8948206
Compare
1fa7237 to
43f6795
Compare
# Conflicts: # Makefile
sources should be URL.
65cf75a to
8852519
Compare
nicolo-ribaudo
commented
Sep 26, 2019
.../babel-plugin-transform-react-jsx-source/test/fixtures/react-source/with-source/options.json
Outdated
Show resolved
Hide resolved
hzoo
reviewed
Sep 26, 2019
Member
Author
|
✔️ (I can't approve my own PR) |
Contributor
|
✔️(me neither) |
hzoo
approved these changes
Sep 26, 2019
Member
hzoo
left a comment
There was a problem hiding this comment.
glad we finally got this in!
Curious of how to maintain adding .replace(/\\/g, "/") everywhere but I guess that's exactly what this CI is for when we encounter that issue!
nicolo-ribaudo
added a commit
that referenced
this pull request
Sep 26, 2019
* Add windows to travis * Update * Do not use sh file on windows * Fix whitespace * Unify command * ./ doesn't work on windows * Remove all ./ usages * Run windows test before others * fix: normalize filename when generating sources sources should be URL. * fix: replace normalized path to cwd * chore: add nodePlatform task options * fix: normalize preset-env filename output * chore: replace normalized path to CWD on win32 platform * limit transform-react-source to run on linux and darwin * test: escapeRegExp on testcases * test: add test for babel --filename on windows * test: double babel-node/cli test timeout * chore: workaround windows build does not stop * chore: remove redundant condition * refactor: rename `nodePlatform` to `os`
This was referenced Oct 22, 2019
This was referenced Nov 12, 2019
dword-design
pushed a commit
to dword-design/babel
that referenced
this pull request
Nov 15, 2019
* Add windows to travis * Update * Do not use sh file on windows * Fix whitespace * Unify command * ./ doesn't work on windows * Remove all ./ usages * Run windows test before others * fix: normalize filename when generating sources sources should be URL. * fix: replace normalized path to cwd * chore: add nodePlatform task options * fix: normalize preset-env filename output * chore: replace normalized path to CWD on win32 platform * limit transform-react-source to run on linux and darwin * test: escapeRegExp on testcases * test: add test for babel --filename on windows * test: double babel-node/cli test timeout * chore: workaround windows build does not stop * chore: remove redundant condition * refactor: rename `nodePlatform` to `os`
This was referenced Nov 28, 2019
This was referenced Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is collaborated by @nicolo-ribaudo and @JLHwung.
In this PR, we
osto babel-helper-fixtures, which specifies the operating system that the test will run on