Merged
Conversation
If the log path did not exist, it would silently fallover to printing all output (DEBUG) to stderr. Also add support for accepting paths via env vars.
babarot
approved these changes
Feb 20, 2025
Owner
babarot
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Owner
That's right. Debug logs are probably only useful for troubleshooting—or for me, really. It might be a good idea to enable them via a config file or only output them when |
Merged
Merged
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Mar 6, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [babarot/gomi](https://github.com/babarot/gomi) | minor | `v1.4.3` -> `v1.5.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>babarot/gomi (babarot/gomi)</summary> ### [`v1.5.1`](https://github.com/babarot/gomi/blob/HEAD/CHANGELOG.md#v151---2025-02-23) [Compare Source](babarot/gomi@v1.5.0...v1.5.1) ##### New Features - Add Log Rotation feature by [@​babarot](https://github.com/babarot) in babarot/gomi#82 ### [`v1.5.0`](https://github.com/babarot/gomi/blob/HEAD/CHANGELOG.md#v150---2025-02-21) [Compare Source](babarot/gomi@v1.4.3...v1.5.0) ##### New Features - Add Permanent Deletion Feature with Confirmation Dialog by [@​babarot](https://github.com/babarot) in babarot/gomi#79 ##### Refactorings - Large-scale Code Refactoring for Better Architecture by [@​babarot](https://github.com/babarot) in babarot/gomi#81 ##### Others - Create missing log path by [@​kariudo](https://github.com/kariudo) in babarot/gomi#80 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xODIuNCIsInVwZGF0ZWRJblZlciI6IjM5LjE4Mi40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
Create missing logpath, and support environment variables.
WHY
Log path not completely existing would cause failover to stderr output, and environment variables for log and config path were not used if not blank.
Sidenote
There should probably configurable support for log verbosity, theres a pretty large volume of logging for each run flowing through the charm log right now, since most people probably wont ever look at the log, logging debug by default (warn/error instead) is probably overkill and just going to slowly eat disk.