Fix files with dollar signs in names being incorrectly expanded#111
Merged
Fix files with dollar signs in names being incorrectly expanded#111
Conversation
Remove environment variable expansion from expandPath in the put command. File arguments should be treated literally — expanding $var in filenames causes them to silently resolve to wrong paths or empty strings. Closes #105
Contributor
Code Metrics Report
Details | | main (1e162c7) | #111 (7379737) | +/- |
|---------------------|----------------|----------------|------|
| Coverage | 50.0% | 50.0% | 0.0% |
| Files | 23 | 23 | 0 |
| Lines | 1087 | 1087 | 0 |
| Covered | 544 | 544 | 0 |
| Code to Test Ratio | 1:0.8 | 1:0.8 | 0.0 |
| Code | 2713 | 2713 | 0 |
| Test | 2321 | 2321 | 0 |
| Test Execution Time | 2s | 2s | 0s |Reported by octocov |
Merged
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Mar 25, 2026
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [babarot/gomi](https://github.com/babarot/gomi) | patch | `v1.6.2` → `v1.6.3` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>babarot/gomi (babarot/gomi)</summary> ### [`v1.6.3`](https://github.com/babarot/gomi/blob/HEAD/CHANGELOG.md#v163---2026-03-20) [Compare Source](babarot/gomi@v1.6.2...v1.6.3) ##### Bug fixes - Fix files with dollar signs in names being incorrectly expanded by [@​babarot](https://github.com/babarot) in [#​111](babarot/gomi#111) - Fix cross-device link error in legacy storage by [@​babarot](https://github.com/babarot) in [#​112](babarot/gomi#112) ##### Improvements - Fix empty files being excluded from restore list by [@​babarot](https://github.com/babarot) in [#​110](babarot/gomi#110) - Fix gomi\_dir being ignored when strategy is auto by [@​babarot](https://github.com/babarot) in [#​113](babarot/gomi#113) - Fix colors invisible on light terminal backgrounds by [@​babarot](https://github.com/babarot) in [#​114](babarot/gomi#114) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My44Ny4xIiwidXBkYXRlZEluVmVyIjoiNDMuODcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6OnBhdGNoIl19-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a bug where files containing
$in their names cannot be trashed becauseexpandPathinterprets them as environment variable references.Background
Reported in Issue #105. When a user runs
gomi '$var'(with shell quoting to prevent shell expansion), theexpandPathfunction callsos.ExpandEnvon the path, which resolves$varto its environment variable value (or empty string if unset). This causes the file to either not be found or to silently operate on a wrong path.Environment variable expansion in file arguments is the shell's responsibility, not the application's. The
forbiddenPathsconfig values (e.g.$HOME/.gomi) are correctly expanded separately inisForbiddenPath, so this change has no side effects.Changes
cli/put.go: Replace theexpandPathimplementation — remove allos.ExpandEnvcalls and usefilepath.Cleanonly. File arguments are now treated literally, preserving$and other special characters in filenames.Closes #105