👍

Nice!

This is sooo good.

I commented on the other thread too, but a 👍 from me. It looks great alongside the other Yosemite icons. Hope this one gets merged.

👍

Really nice 👍

👍

I'm not loving the low contrast. The V, especially in the upper left, starts to fade into the background. It's certainly more Yosemite-ish, and probably even better looking, but not nearly as iconic.

👍

@natw I disagree, it fits perfectly in my yosemite context. Contrast is good too :)

The shadow is a bit wonky. It's not soft and is just offset vertically. This won't work super well alongside other app icons. The shadow form the 'V' can be sharper against the diamond, but not against the background.

The styling of the shapes (inner shadows) feels strange and would work better if removed, especially when the icon is scaled down.

The serifs on the 'V' shape are extremely rounded, creating a fully rounded end-cap, which is highly unusually for a typeface and distracting because of it.

If you're using a green color close enough to the ones used on Apple's own iOS and OS X apps, just use the same exact color(s), otherwise it creates inconsistency and dissonance.

The icon I've proposed in #43 solves some of these issues. I started working on that icon before even realizing there were discussions about it.

Shown below is the 128x128 version of the icon I've proposed.

@mdznr I have to say I disagree with most of this. The shadows are cast vertically because the light source of Yosemite icons is directly above. The inner and outer shadows here match up very close to the reference Yosemite icons I have, as do the gradients. I've tweaked the shadows at the smaller sizes in my .icns. And I definitely don't agree with using the exact same green that Apple is using for their icons.

@jasonlong

Sorry, I should've been more clear. Yes, the shadow will still cast down vertically, but it should be blurred more. Right now it is very sharp (not a lot of depth between the shape and the background). This is not how the other app icons (especially Apple's) are.

The inner shadows are several pixels thick and are very dark and very light. This is not how they appear on the Yosemite icons.

Not every icon needs to be limited to the small color palette, yes. However, the green shown above is treading too close to the standard green Apple is using. If you don't wish to use that green, move further away from it, otherwise it looks and feels like a mismatch and not a deliberate choice.

Ok, I took a closer look at the shadows and made some tweaks. I think these are looking better do indeed match the reference icons better.

I still don't buy the green argument (and I'm pretty fond of this color). There are going to be a zillion green app icons all over the spectrum, including shades of light green. I don't believe that there should be some value where icon colors should "snap" to Apple's lime green.

awesomesauce 👍

Awesome icon! I just wanted to ask, if someone could also generate the custom-filetype-icons using this design. The scripts to generate them haven't worked for me since Mountain Lion :(

Folks, @jocelynmallon has done a fine job of merging all these pull requests and documented how to install it on her blog: https://girlintroverted.wordpress.com/2014/11/06/macvim-for-yosemite/

It's worth checking out. Kudos go to @jocelynmallon (you rock!).

@shaond 👍

Great work @jocelynmallon

👍 I like this icon

@jasonlong did you submit this via mailing list? I'm not sure that @b4winckler monitors this repo here. Maybe soon now that Google Code is shutting down.

I don't know if this repository is monitored at all. See https://groups.google.com/forum/m/#!topic/vim_mac/-bd5RKGs8qw and https://github.com/macvim-dev/macvim

Thanks for the heads-up @simono. I'll submit a PR over on @macvim-dev's repo.

👍

I love it! What a delightful surprise when I ran brew upgrade today.

Yeah, @johnstephens is right! So the new icon is there, but the MR is still opened. What kind of magic happened here?

@jtheoof see macvim-dev/macvim#1

Going to close this. For those interested, the icon is now available in https://github.com/macvim-dev/macvim which is what homebrew uses now.