Don't double-encode URLs before parsing them#33
Merged
b4winckler merged 1 commit intob4winckler:masterfrom Sep 6, 2013
s4y:patch-1
Merged
Don't double-encode URLs before parsing them#33b4winckler merged 1 commit intob4winckler:masterfrom s4y:patch-1
b4winckler merged 1 commit intob4winckler:masterfrom
s4y:patch-1
Conversation
<https://code.google.com/p/macvim/issues/detail?id=316> wasn't a bug. When you're constructing a URL, you *should* end up escaping URL-unsafe characters twice: once for the `file:` URL and once for the `mvim:` URL. Escaping it inside MacVim breaks legit URLs with escapes at the `mvim:` level.
b4winckler
added a commit
that referenced
this pull request
Sep 6, 2013
Don't double-encode URLs before parsing them
Owner
|
Thanks! For some reason I forgot about to review this pull request...sorry about that. |
Contributor
Author
|
Sweet! No worries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7 (316) wasn't a bug. When someone constructs a
mvim:URL, they should end up escaping the unsafe characters in the path twice: once for thefile:URL (e.g.file://Users/steve/foo%20bar/baz.txt) and again for themvim:URL.Escaping the whole thing inside MacVim, like this fix did, breaks legit URLs. Here's an example in Python:
In ObjC, the slashes and colon aren't escaped (equally valid as what Python does) but the space does get correctly double-escaped, so same breakage: