Skip to content

CI: improve release workflow safety and enable changelog#39

Merged
azu merged 1 commit intomainfrom
fix/release-workflow-improvements
Apr 4, 2026
Merged

CI: improve release workflow safety and enable changelog#39
azu merged 1 commit intomainfrom
fix/release-workflow-improvements

Conversation

@azu
Copy link
Copy Markdown
Owner

@azu azu commented Apr 4, 2026

Summary

This PR fixes a shell safety issue in the release workflow and enables goreleaser's built-in changelog generation.

Changes

  • Replace echo "$PR_BODY" with printenv PR_BODY in release workflow to prevent shell interpretation of special characters (e.g., backticks, dollar signs) in PR body content when writing release notes
  • Remove changelog: disable: true from .goreleaser.yml to enable goreleaser's automatic changelog generation for releases

Breaking Changes

None

Test Plan

  • Verify the release workflow runs correctly by creating a release PR
  • Confirm that release notes are properly written to /tmp/release-notes.md without shell interpretation issues
  • Confirm goreleaser generates a changelog in the GitHub release

Use printenv instead of echo for PR_BODY to prevent shell interpretation
of special characters in release notes. Remove changelog disable setting
to let goreleaser generate changelogs.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@azu azu added the Type: CI Changes to CI configuration files and scripts label Apr 4, 2026
@azu azu enabled auto-merge (squash) April 4, 2026 01:53
@azu azu merged commit 3f5f054 into main Apr 4, 2026
2 of 3 checks passed
@azu azu deleted the fix/release-workflow-improvements branch April 4, 2026 01:54
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@github-actions github-actions Bot mentioned this pull request Apr 5, 2026
azu pushed a commit that referenced this pull request Apr 5, 2026
<!-- Release notes generated using configuration in .github/release.yml
at main -->

## What's Changed
### Bug Fixes
* Fix transient error caching, digest slice panic, and file permission
overwrite by @Copilot in #41
### CI
* CI: improve release workflow safety and enable changelog by @azu in
#39

## New Contributors
* @Copilot made their first contribution in
#41

**Full Changelog**:
v1.2.1...v1.2.2

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: CI Changes to CI configuration files and scripts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant