Skip to content

refactor(cli): update keypair generate command#1621

Merged
Flouse merged 12 commits intomainfrom
refactor-keypair
Dec 13, 2023
Merged

refactor(cli): update keypair generate command#1621
Flouse merged 12 commits intomainfrom
refactor-keypair

Conversation

@KaoImin
Copy link
Contributor

@KaoImin KaoImin commented Dec 6, 2023

What this PR does / why we need it?

This PR update the axon keypair generator.

What is the impact of this PR?

No Breaking Change

PR relation:

  • Ref #
CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OpenZeppelin tests
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OpenZeppelin tests Run the compatibility tests provided by OpenZeppelin, including OCT 1-5 | 6-10 | 11 | 12-15 | 16-19

@KaoImin KaoImin requested a review from a team as a code owner December 6, 2023 06:17
@KaoImin KaoImin requested review from Flouse, Simon-Tl, jjyr and wenyuanhust and removed request for jjyr and wenyuanhust December 6, 2023 06:17
@chaoticlonghair
Copy link
Contributor

chaoticlonghair commented Dec 6, 2023

Questions

Not for your PR, your PR is fine, just ask for future plans.

  • Not in CI (or no tests in CI), how to guarantee availability after another PR?
  • Is it contained in releases?
    • Why not be a subcommond of Axon? So users don't have to use two binaries?
  • Should it contain the peer-id calculation?
    Today, when I generate a new network key, I have to use CKB to display the peer-id.

@Flouse
Copy link
Contributor

Flouse commented Dec 6, 2023

  • Should it contain the peer-id calculation?

Do you mean this peer-id?

@chaoticlonghair
Copy link
Contributor

chaoticlonghair commented Dec 6, 2023 •
edited
Loading

  • Should it contain the peer-id calculation?

Do you mean this peer-id?

I reviewed the CLI arguments, if I have a network private key, there is no command to display its info.
Same for BLS key, but network key is more likely to be used, because you have to tell people who want to connect you every time.

If you have more than 1 keys, it's possible you could mix them up.

@Flouse Flouse mentioned this pull request Dec 6, 2023
Closed
@KaoImin KaoImin marked this pull request as draft December 6, 2023 23:48
@KaoImin
Copy link
Contributor Author

KaoImin commented Dec 6, 2023

Questions

Not for your PR, your PR is fine, just ask for future plans.

  • Not in CI (or no tests in CI), how to guarantee availability after another PR?

  • Is it contained in releases?

    • Why not be a subcommond of Axon? So users don't have to use two binaries?

  • Should it contain the peer-id calculation?
    Today, when I generate a new network key, I have to use CKB to display the peer-id.

I am integrating the keypair generator into Axon binary.

@KaoImin KaoImin changed the title refactor(devtools): update keypair generator refactor(cli): update keypair generate command Dec 11, 2023
@KaoImin KaoImin marked this pull request as ready for review December 13, 2023 03:20
Flouse
Flouse reviewed Dec 13, 2023
View reviewed changes
Flouse
Flouse reviewed Dec 13, 2023
View reviewed changes
Eason Gao and others added 3 commits December 13, 2023 14:33
@Flouse
Update core/cli/README.md
d02f1da 
Co-authored-by: Flouse <1297478+Flouse@users.noreply.github.com>
@Flouse
Update core/cli/README.md
91f03e6 
Co-authored-by: Flouse <1297478+Flouse@users.noreply.github.com>
@Flouse
Update core/cli/README.md
cec8616 
Co-authored-by: Flouse <1297478+Flouse@users.noreply.github.com>
@KaoImin KaoImin requested a review from Flouse December 13, 2023 07:24
@Flouse Flouse enabled auto-merge December 13, 2023 08:53
@Flouse Flouse added this pull request to the merge queue Dec 13, 2023
Merged via the queue into main with commit 44fa697 Dec 13, 2023
Flouse added a commit that referenced this pull request Dec 13, 2023
@Flouse
Backport #1634 #1621 to 0.3.x-dev
0baa699
Flouse added a commit that referenced this pull request Dec 13, 2023
@Flouse
docs: add #1621 and #1634 into CHANGELOG
588c276
Flouse added a commit that referenced this pull request Dec 18, 2023
@Flouse
docs: add #1621 and #1634 into CHANGELOG
4e88781
github-merge-queue bot pushed a commit that referenced this pull request Dec 18, 2023
@Flouse
chore: bump Axon version to 0.3.0-beta (#1627)
983f023 
* chore: bump axon version to 0.3.0-beta

* chore(docker): build ghcr image for alpha branch

* docs: add #1621 and #1634 into CHANGELOG
@KaoImin KaoImin deleted the refactor-keypair branch December 28, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Flouse Flouse Flouse approved these changes

+1 more reviewer

@Simon-Tl Simon-Tl Simon-Tl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KaoImin @chaoticlonghair @Flouse @Simon-Tl