Skip to content

chore: make blst portable#1520

Merged
chaoticlonghair merged 1 commit intoaxonweb3:mainfrom
blckngm:blst-portable
Nov 2, 2023
Merged

chore: make blst portable#1520
chaoticlonghair merged 1 commit intoaxonweb3:mainfrom
blckngm:blst-portable

Conversation

@blckngm
Copy link
Contributor

@blckngm blckngm commented Nov 2, 2023 •
edited
Loading

What this PR does / why we need it?

This PR enables the portable feature of the blst crate so that axon won't use ADX instructions.

From blst readme:

If final application crashes with an "illegal instruction" exception [after copying to another system], [...] And if you compile a Rust application, you can pass --features portable to cargo build.

What is the impact of this PR?

No Breaking Change

PR relation:

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@blckngm blckngm requested a review from a team as a code owner November 2, 2023 01:09
@blckngm
Copy link
Contributor Author

blckngm commented Nov 2, 2023

Workflow run where the runner doesn't support ADX: https://github.com/axonweb3/axon/actions/runs/6665823425/job/18116195808#step:5:69

@chaoticlonghair
Copy link
Contributor

chaoticlonghair commented Nov 2, 2023 •
edited
Loading

Sorry, I didn't catch your meaning.

I don't try to reject your PR, it's pretty good.

I'm just curious. I think your PR is a good try, but doesn't be proved to be a final solution from that logs.

@blckngm
Copy link
Contributor Author

blckngm commented Nov 2, 2023

Sorry, I didn't catch your meaning.

* How did you confirm it was caused by ADX? I didn't find any useful log follow the link you pasted.
  > Workflow run where the runner doesn't support ADX: https://github.com/axonweb3/axon/actions/runs/6665823425/job/18116195808#step:5:69

See the build axon step: lscpu says the cpu is E5-2673 v3, and it doesn't support ADX (adx is not in the flags). If you look up this CPU on intel website, you'll see it's haswell and indeed doesn't support ADX. ADX is supported since the next generation (broadwell).

@chaoticlonghair
Copy link
Contributor

chaoticlonghair commented Nov 2, 2023 •
edited
Loading

See the build axon step: lscpu says the cpu is E5-2673 v3 ...

Then, you should paste that link to #step:4:24. 🤓 But you pointed to #step:5:69.

@KaoImin KaoImin added this pull request to the merge queue Nov 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 2, 2023
@chaoticlonghair
Copy link
Contributor

chaoticlonghair commented Nov 2, 2023 •
edited
Loading

Merge CI failed since failures: tests::system_script::metadata::test_write_functions. (ref: #1374 (comment))

@chaoticlonghair chaoticlonghair added this pull request to the merge queue Nov 2, 2023
Merged via the queue into axonweb3:main with commit 552b328 Nov 2, 2023
@Flouse Flouse mentioned this pull request Nov 15, 2023
Open
KaoImin pushed a commit that referenced this pull request Nov 17, 2023
@blckngm
chore: make blst portable (#1520)
9604975
@chaoticlonghair chaoticlonghair mentioned this pull request Nov 17, 2023
Closed
@Flouse Flouse mentioned this pull request Dec 14, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wenyuanhust wenyuanhust Awaiting requested review from wenyuanhust wenyuanhust is a code owner automatically assigned from axonweb3/axon-dev

@sunchengzhu sunchengzhu Awaiting requested review from sunchengzhu sunchengzhu is a code owner automatically assigned from axonweb3/axon-dev

2 more reviewers

@KaoImin KaoImin KaoImin approved these changes

@chaoticlonghair chaoticlonghair chaoticlonghair approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI may be broken by illegal instruction

3 participants

@blckngm @chaoticlonghair @KaoImin