Skip to content

refactor: remove the limitation of set ckb related info#1517

Merged
KaoImin merged 2 commits intomainfrom
refactor-metadata
Oct 30, 2023
Merged

refactor: remove the limitation of set ckb related info#1517
KaoImin merged 2 commits intomainfrom
refactor-metadata

Conversation

@KaoImin
Copy link
Contributor

@KaoImin KaoImin commented Oct 30, 2023 •
edited
Loading

What this PR does / why we need it?

This PR remove the limitation of set_ckb_related_info in metadata system contract. The method can be called by a validator in any time. After set the info, developer can get the info through rpc axon_getCkbRelatedInfo.
Besides, add some annotation for the common_ref of OverlordCrypto.

What is the impact of this PR?

No Breaking Change

PR relation:

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@KaoImin KaoImin requested a review from a team as a code owner October 30, 2023 02:10
@KaoImin KaoImin requested review from Flouse, ashuralyk, driftluo, sunchengzhu and wenyuanhust and removed request for sunchengzhu and wenyuanhust October 30, 2023 02:10
@KaoImin KaoImin enabled auto-merge October 30, 2023 06:41
@KaoImin KaoImin disabled auto-merge October 30, 2023 06:41
@KaoImin KaoImin added this pull request to the merge queue Oct 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2023
@KaoImin KaoImin added this pull request to the merge queue Oct 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2023
@KaoImin KaoImin added this pull request to the merge queue Oct 30, 2023
Merged via the queue into main with commit 166506f Oct 30, 2023
@KaoImin KaoImin deleted the refactor-metadata branch October 31, 2023 01:55
KaoImin pushed a commit that referenced this pull request Nov 17, 2023
refactor: remove the limitation of set ckb related info (#1517)
51ff8ba 
* refactor: remove  limitation of set ckb related info

* style: add some annotation
@chaoticlonghair chaoticlonghair mentioned this pull request Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Flouse Flouse Flouse approved these changes

@driftluo driftluo driftluo approved these changes

@ashuralyk ashuralyk Awaiting requested review from ashuralyk

Assignees

No one assigned

Labels

refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Asking for a magic string in BLS signature: where does it come from?

3 participants

@KaoImin @Flouse @driftluo