Skip to content

refactor(network): immutable chain id#1351

Merged
KaoImin merged 1 commit intomainfrom
yangby/refactor/immutable-chain-id
Aug 24, 2023
Merged

refactor(network): immutable chain id#1351
KaoImin merged 1 commit intomainfrom
yangby/refactor/immutable-chain-id

Conversation

@chaoticlonghair
Copy link
Contributor

@chaoticlonghair chaoticlonghair commented Aug 23, 2023

What this PR does / why we need it?

This PR:

  • Make the chain id in network service to be immutable.
  • Remove a comment which breaks the code format.

What is the impact of this PR?

No Breaking Change

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@chaoticlonghair chaoticlonghair requested a review from a team as a code owner August 23, 2023 09:30
@chaoticlonghair chaoticlonghair requested review from Flouse, KaoImin, ashuralyk, blckngm and driftluo and removed request for ashuralyk and blckngm August 23, 2023 09:30
@KaoImin KaoImin added this pull request to the merge queue Aug 24, 2023
Merged via the queue into main with commit 1f0ddfa Aug 24, 2023
@chaoticlonghair chaoticlonghair deleted the yangby/refactor/immutable-chain-id branch August 24, 2023 06:04
KaoImin pushed a commit that referenced this pull request Aug 25, 2023
@chaoticlonghair
refactor(network): immutable chain id (#1351)
62df4cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Flouse Flouse Flouse approved these changes

@driftluo driftluo Awaiting requested review from driftluo

+1 more reviewer

@KaoImin KaoImin KaoImin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chaoticlonghair @Flouse @KaoImin