Conversation
2b720d0 to
e9d8789
Compare
Contributor
Author
|
/run-ci |
CI tests run on commit:
CI test list:Please check ci test results later. |
cce4df0 to
c77c927
Compare
blckngm
reviewed
Mar 31, 2023
blckngm
reviewed
Mar 31, 2023
| start = len; | ||
| } | ||
|
|
||
| let mut end = start.wrapping_add(size); |
Contributor
There was a problem hiding this comment.
If this actually wraps, won't data[start..end] panic? How about using saturating_add instead.
Contributor
|
It might still be better to calculate gas cost without allocating for full |
c77c927 to
f9090a8
Compare
Contributor
|
/run-ci |
CI tests run on commit:
CI test list:
Please check ci test results later. |
KaoImin
approved these changes
Apr 3, 2023
KaoImin
previously approved these changes
Apr 3, 2023
f9090a8 to
7636e33
Compare
Contributor
|
/run-ci |
CI tests run on commit:
CI test list:
Please check ci test results later. |
KaoImin
approved these changes
Apr 3, 2023
hongda3141
pushed a commit
to hongda3141/axon
that referenced
this pull request
Apr 10, 2023
parent 98a8216 author michael <michael@michael> 1679672226 +0800 committer michael <michael@michael> 1681098977 +0800 parent 98a8216 author michael <michael@michael> 1679672226 +0800 committer michael <michael@michael> 1681098964 +0800 feat(eip-155): init add logic and e2e test case fix: handle panic and add one unit test style: optimize redundancy test: add rawtx test style: cargo fmt fix: change u64 to option of chain_id style: lint test: fix test result test: add EIP-155 and preEIP-155 tests test: add pre-eip-155 legacy encode test case test: add legacy with chain_id test case test: add eip1820 test cases chore(deps): bump serde from 1.0.157 to 1.0.159 (axonweb3#1114) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> refactor: change the bound of ExecutorAdapter trait (axonweb3#1112) chore(deps): bump proc-macro2 from 1.0.52 to 1.0.55 (axonweb3#1132) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> feat(executor): remove modexp limit (axonweb3#1119) refactor: change the maximum RPC gas cap limit (axonweb3#1133) chore(deps): bump peter-evans/create-pull-request from 4 to 5 (axonweb3#1141) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR:
Special notes for your reviewer:
NIL
CI Description
cargo clippy --all --all-targets --all-featurescargo +nightly fmt --all -- --checkandcargo sort -gwcCI Usage
CI Switch