Skip to content

feat: support pre EIP-155 transaction#1111

Merged
KaoImin merged 2 commits intoaxonweb3:mainfrom
hongda3141:@michael/non-eip-155
Apr 12, 2023
Merged

feat: support pre EIP-155 transaction#1111
KaoImin merged 2 commits intoaxonweb3:mainfrom
hongda3141:@michael/non-eip-155

Conversation

@hongda3141
Copy link
Contributor

@hongda3141 hongda3141 commented Mar 24, 2023 •
edited by KaoImin
Loading

add logic and e2e test case

What this PR does / why we need it:

This PR

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

NIL

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

@hongda3141 hongda3141 changed the title fix: recover sender of non EIP-155 txs [WIP]fix: recover sender of non EIP-155 txs Mar 25, 2023
@hongda3141 hongda3141 force-pushed the @michael/non-eip-155 branch from df3438c to 6867c59 Compare March 26, 2023 13:38
@hongda3141 hongda3141 marked this pull request as ready for review March 26, 2023 15:26
@hongda3141 hongda3141 requested a review from a team as a code owner March 26, 2023 15:26
@hongda3141 hongda3141 changed the title [WIP]fix: recover sender of non EIP-155 txs fix: recover sender of non EIP-155 txs Mar 26, 2023
@hongda3141
Copy link
Contributor Author

hongda3141 commented Mar 26, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Mar 26, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Unit Tests

Please check ci test results later.

@hongda3141 hongda3141 changed the title fix: recover sender of non EIP-155 txs [WIP]fix: recover sender of non EIP-155 txs Mar 26, 2023
@hongda3141 hongda3141 changed the title [WIP]fix: recover sender of non EIP-155 txs [WIP]fix: recover sender of pre EIP 155 txs Mar 27, 2023
@hongda3141 hongda3141 changed the title [WIP]fix: recover sender of pre EIP 155 txs [WIP]fix: recover sender of pre-EIP-155 txs Mar 27, 2023
@KaoImin KaoImin marked this pull request as draft March 28, 2023 06:39
@hongda3141 hongda3141 changed the title [WIP]fix: recover sender of pre-EIP-155 txs fix: recover pre-EIP-155 txs Mar 28, 2023
@hongda3141
Copy link
Contributor Author

hongda3141 commented Mar 28, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Mar 28, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • Unit Tests

Please check ci test results later.

@hongda3141
Copy link
Contributor Author

hongda3141 commented Mar 28, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Mar 28, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • Unit Tests

Please check ci test results later.

@hongda3141
Copy link
Contributor Author

hongda3141 commented Mar 28, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Mar 28, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • Unit Tests

Please check ci test results later.

@hongda3141 hongda3141 marked this pull request as ready for review March 29, 2023 00:27
@KaoImin
Copy link
Contributor

KaoImin commented Apr 1, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Apr 1, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • Chaos CI
  • E2E Tests
  • OCT 1-5 And 12-15
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin
Copy link
Contributor

KaoImin commented Apr 1, 2023

/run-ci

1 similar comment
@KaoImin
Copy link
Contributor

KaoImin commented Apr 1, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Apr 1, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • OCT 1-5 And 12-15
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

1 similar comment
@axon-bot
Copy link

axon-bot bot commented Apr 1, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • OCT 1-5 And 12-15
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@hongda3141
Copy link
Contributor Author

hongda3141 commented Apr 2, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Apr 2, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • OCT 1-5 And 12-15
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin KaoImin marked this pull request as draft April 3, 2023 03:43
@hongda3141
Copy link
Contributor Author

hongda3141 commented Apr 10, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Apr 10, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • OCT 1-5 And 12-15
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@dependabot
feat: eip-155
3941e9c 
parent 98a8216
author michael <michael@michael> 1679672226 +0800
committer michael <michael@michael> 1681098977 +0800

parent 98a8216
author michael <michael@michael> 1679672226 +0800
committer michael <michael@michael> 1681098964 +0800

feat(eip-155): init

add logic and e2e test case

fix: handle panic and add one unit test

style: optimize redundancy

test: add rawtx test

style: cargo fmt

fix: change u64 to option of chain_id

style: lint

test: fix test result

test: add EIP-155 and preEIP-155 tests

test: add pre-eip-155 legacy encode test case

test: add legacy with chain_id test case

test: add eip1820 test cases

chore(deps): bump serde from 1.0.157 to 1.0.159 (axonweb3#1114)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

refactor: change the bound of ExecutorAdapter trait (axonweb3#1112)

chore(deps): bump proc-macro2 from 1.0.52 to 1.0.55 (axonweb3#1132)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

feat(executor): remove modexp limit (axonweb3#1119)

refactor: change the maximum RPC gas cap limit (axonweb3#1133)

chore(deps): bump peter-evans/create-pull-request from 4 to 5 (axonweb3#1141)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@hongda3141 hongda3141 force-pushed the @michael/non-eip-155 branch from df788fb to 3941e9c Compare April 10, 2023 03:57
@hongda3141
Copy link
Contributor Author

hongda3141 commented Apr 10, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Apr 10, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • OCT 1-5 And 12-15
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin KaoImin marked this pull request as ready for review April 11, 2023 01:44
@KaoImin KaoImin changed the title fix: recover pre-EIP-155 txs feat: support recover pre-EIP-155 txs Apr 12, 2023
@KaoImin KaoImin changed the title feat: support recover pre-EIP-155 txs feat: support pre-EIP-155 transaction Apr 12, 2023
@KaoImin KaoImin changed the title feat: support pre-EIP-155 transaction feat: support pre EIP-155 transaction Apr 12, 2023
@KaoImin KaoImin added this pull request to the merge queue Apr 12, 2023
Merged via the queue into axonweb3:main with commit b000be4 Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterzhb peterzhb Awaiting requested review from peterzhb peterzhb is a code owner automatically assigned from axonweb3/axon-dev

@felicityin felicityin Awaiting requested review from felicityin felicityin is a code owner automatically assigned from axonweb3/axon-dev

1 more reviewer

@KaoImin KaoImin KaoImin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hongda3141 @KaoImin