Skip to content

Conversation

@DelinWorks
Copy link
Contributor

Refer to #733

@halx99
Copy link
Collaborator

halx99 commented Jul 8, 2022

Maybe your step still incorrect

@DelinWorks
Copy link
Contributor Author

I've merged migrate-engine-name into migrate-engine-name-2 and created a PR

@halx99
Copy link
Collaborator

halx99 commented Jul 8, 2022

Maybe your step still incorrect

It looks like you create the branch from your own branch dev, not upstream dev?

@halx99
Copy link
Collaborator

halx99 commented Jul 8, 2022

I've merged migrate-engine-name into migrate-engine-name-2 and created a PR

It will inhert the commit history

@halx99
Copy link
Collaborator

halx99 commented Jul 8, 2022

I viewed the changes file, this branch looks correct

@DelinWorks
Copy link
Contributor Author

DelinWorks commented Jul 8, 2022

nice

@halx99
Copy link
Collaborator

halx99 commented Jul 8, 2022

There is a way to merge all commit into one:

# find the latest commit hash of upstream `dev`
git log

# reset without local changes reverts to the hash
git reset --soft <latest commit hash of upstream dev>

# Now you can only add on commit to your local branch
git commit -m "Example commit message"

And you don't need do it at this time, I will use Squash and merge button to erase unnecessary commits history by github automatically.
image

@DelinWorks
Copy link
Contributor Author

DelinWorks commented Jul 8, 2022

Search "adxe" (0 hits in 0 files of 1251 searched) done with core you can merge now.
ci is failing because of extensions I will do the replacement later

@halx99 halx99 merged commit 8517d0e into axmolengine:dev Jul 8, 2022
@halx99
Copy link
Collaborator

halx99 commented Jul 8, 2022

And the android ci failed because you change the engine adxetools.gradle which is depended by all tests & template projects

halx99 pushed a commit that referenced this pull request Jun 6, 2025
This release fixes a bug that very occasionally caused an endless loop (see GitHub issues #735 & #979)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants