Fix sprite sheet creation logic #2978
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Instead of creating new SpriteSheet on loading, Now it'll check if that SpriteSheet already exists, if it does use and fill it otherwise create new.
Let me know if needs more details or other issues in the PR.
Issue ticket number and link
Currently if SpriteSheet is partially deleted by android/ios partial memory cleanup. Reloading it again loads only missing sprites to a new SpriteSheet and marks it as
fullbut it's not full. So If the cleanup happens again some sprites will be missed an not loaded again even after multiple tries.Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."I have performed a self-review of my code.
Optional:
For core/new feature PR
Axmol 3.x ------------------------------------------------------------
For each 3.x PR