Fix memory leak in extension::GUI ScrollView. #2821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Maybe shoud target branch |
_animatedScrollAction is retained but was not released on destruction of the ScrollView.
816decb to
0857248
Compare
halx99
approved these changes
Oct 16, 2025
tkzcfc
pushed a commit
to tkzcfc/axmol
that referenced
this pull request
Oct 17, 2025
* release/2.x: Fix memory leak in extension::GUI ScrollView. (axmolengine#2821) Add new test scroll view v2 (axmolengine#2820) AutoPolygon::findFirstNoneTransparentPixel() detected Y pos is 1 pixe… (axmolengine#2810)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_animatedScrollAction is retained but was not released on destruction of the ScrollView.
Describe your changes
Issue ticket number and link
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."I have performed a self-review of my code.
Optional:
For core/new feature PR
Axmol 3.x ------------------------------------------------------------
For each 3.x PR