Add Device::resolveOrientation and compact resolution logic #2792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogic Introduce Device::resolveOrientation to deterministically choose the app’s effective orientation from supported, preferred, and physical orientations. The logic guarantees the result is always compatible with the supported mask and avoids transient incorrect sizes at startup (notably on iOS). Key points: - Add resolveOrientation() in Device as the single public API for orientation decision. - Implement compact resolution flow with tryUse helper to reduce duplication. - Use resolvedOrientation naming (avoid C++ keyword 'final') for clarity. - Keep FaceUp/FaceDown/Unknown safely falling back to supported defaults. - iOS uses this to compute logical screen size before app->run(); Android can return current orientation for parity. Why: - Centralize orientation decision in Device, decoupling it from view/sizing code. - Prevent initial flicker and wrong layout caused by UIKit’s portrait-based bounds at launch. - Improve readability and maintainability across platforms. Impact: - No breaking changes to callers; RenderViewImpl-ios now consumes Device::resolveOrientation. - Orientation result is stable and in-mask; downstream size/viewport code becomes simpler. Test plan: - Unit test matrix across (preferred x physical x supported) including Sensor*, concrete, and unknown cases. - Validate FaceUp/FaceDown → fallback behavior. - Manual on iOS: cold start in portrait/landscape/flat; verify initial frame matches resolved orientation. - Manual on Android: ensure parity and no regression in Activity orientation.
tkzcfc
pushed a commit
to tkzcfc/axmol
that referenced
this pull request
Sep 23, 2025
* release/2.x: Committing luabindings for commit 44833f4 (axmolengine#2794) Add Device::resolveOrientation and compact resolution logic (axmolengine#2792)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce Device::resolveOrientation to deterministically choose the app’s effective orientation from supported, preferred, and physical orientations. The logic guarantees the result is always compatible with the supported mask and avoids transient incorrect sizes at startup (notably on iOS).
Key points:
Why:
Impact:
Test plan:
Describe your changes
Issue ticket number and link
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."I have performed a self-review of my code.
Optional:
For core/new feature PR
Axmol 3.x ------------------------------------------------------------
For each 3.x PR